Complete WebStateObserverBridge and follow Cocoa naming style.

Complete WebStateObserverBridge and follow Cocoa naming style.

Adds remaining WebStateObserver methods to WebStateObserverBridge and
updates CRWWebStateObserver protocol methods to follow Cocoa style
guidelines for naming delegate methods.

Committed: https://crrev.com/92d84dab53d855a8a7bd9f8922d5f70d840f93bf
Cr-Commit-Position: refs/heads/master@{#325277}

[Jackie Quinn, 2015-04-10 21:31:54]

jyquinn@chromium.org changed reviewers:
+ dconnelly@chromium.org, eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2015-04-10 21:37:32]

lgtm

[dconnelly, 2015-04-14 09:13:29]

lgtm

[Jackie Quinn, 2015-04-14 17:31:25]

The CQ bit was checked by jyquinn@chromium.org

[commit-bot: I haz the power, 2015-04-14 17:32:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079693002/1

[Jackie Quinn, 2015-04-14 18:03:26]

jyquinn@chromium.org changed reviewers:
+ droger@chromium.org, sdefresne@chromium.org

[Jackie Quinn, 2015-04-14 18:03:26]

+ sdefrense for Favicons
+ droger for Translate

[commit-bot: I haz the power, 2015-04-14 18:06:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-14 18:06:54]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[droger, 2015-04-14 18:19:00]

Why the change URL -> Url?
I see that WebContents uses URL for example. Is content wrong?

[Jackie Quinn, 2015-04-14 18:24:19]

On 2015/04/14 18:19:00, droger wrote:
> Why the change URL -> Url?
> I see that WebContents uses URL for example. Is content wrong?

The change is to follow the C++ style guide for function names:
https://engdoc.corp.google.com/eng/doc/devguide/cpp/styleguide.shtml?cl=head#...

[Jackie Quinn, 2015-04-14 18:31:46]

On 2015/04/14 18:24:19, jyquinn wrote:
> On 2015/04/14 18:19:00, droger wrote:
> > Why the change URL -> Url?
> > I see that WebContents uses URL for example. Is content wrong?
> 
> The change is to follow the C++ style guide for function names:
>
https://engdoc.corp.google.com/eng/doc/devguide/cpp/styleguide.shtml?cl=head#...

http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Names

[sdefresne, 2015-04-15 08:00:48]

//components/favicon/ios lgtm

[sdefresne, 2015-04-15 08:11:07]

On 2015/04/15 08:00:48, sdefresne wrote:
> //components/favicon/ios lgtm

BTW, regarding URL/Url, I see that URL seems to be much more common (5x more
occurrences of URL than Url) in Chromium code. I don't have any strong opinion
on the method name, but I don't know if using Url instead of URL is more or less
inline with the rest of the code.

[droger, 2015-04-15 08:12:11]

On 2015/04/15 08:11:07, sdefresne wrote:
> On 2015/04/15 08:00:48, sdefresne wrote:
> > //components/favicon/ios lgtm
> 
> BTW, regarding URL/Url, I see that URL seems to be much more common (5x more
> occurrences of URL than Url) in Chromium code. I don't have any strong opinion
> on the method name, but I don't know if using Url instead of URL is more or
less
> inline with the rest of the code.

Yes, that's why I was asking. I remember there used to be an explicit rule to
use caps for acronyms, but I can't find it now, so maybe I'm wrong or this rule
has been removed.

[droger, 2015-04-15 08:14:04]

Translate LGTM though.

[Jackie Quinn, 2015-04-15 17:38:27]

On 2015/04/15 08:14:04, droger wrote:
> Translate LGTM though.

Thanks!

Stuart ran a grep on content to exclude GURL and a few other cases, and ended up
with ~3x difference. We decided that we should follow the style guide for web,
since the code isn't overwhelmingly consistent as it is.

[Jackie Quinn, 2015-04-15 17:38:31]

The CQ bit was checked by jyquinn@chromium.org

[commit-bot: I haz the power, 2015-04-15 17:38:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079693002/1

[commit-bot: I haz the power, 2015-04-15 18:38:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-15 18:46:38]

Patchset 1 (id:??) landed as
https://crrev.com/92d84dab53d855a8a7bd9f8922d5f70d840f93bf
Cr-Commit-Position: refs/heads/master@{#325277}