base/compiler_specific.h - Issue 10796020: Upgrade AlignedMemory to support dynamic allocations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/compiler_specific.h

Issue 10796020: Upgrade AlignedMemory to support dynamic allocations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Change AlignedMemory back to POD. Retry now that NaCl fixed. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/compiler_specific.h

diff --git a/base/compiler_specific.h b/base/compiler_specific.h

index 64273a98db93c4fc0158690958bc7cd4de225d32..5d7d9d11019bd22bc0a9c9e28f06ccb036566a5e 100644

--- a/base/compiler_specific.h

+++ b/base/compiler_specific.h

@@ -114,11 +114,13 @@

#define ALIGNAS(byte_alignment) __attribute__((aligned(byte_alignment)))

#endif

-// Return the byte alignment of the given type (available at compile time).

+// Return the byte alignment of the given type (available at compile time). Use

+// sizeof(type) prior to checking __alignof to workaround Visual C++ bug:

+// http://goo.gl/isH0C

// Use like:

// ALIGNOF(int32) // this would be 4

#if defined(COMPILER_MSVC)

-#define ALIGNOF(type) __alignof(type)

+#define ALIGNOF(type) (sizeof(type) - sizeof(type) + __alignof(type))

#elif defined(COMPILER_GCC)

#define ALIGNOF(type) __alignof__(type)

#endif

« no previous file with comments | « base/base.gypi ('k') | base/memory/aligned_memory.h » ('j') | no next file with comments »