Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1079593004: Switch VP9 lossy to CBR encoding. (Closed)

Created:
5 years, 8 months ago by aconverse
Modified:
5 years, 8 months ago
Reviewers:
Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch VP9 lossy to CBR encoding. CBR is required for cyclic refresh. BUG=134202 Committed: https://crrev.com/d194235c54b414571f6fbdedf47b00592fbfc690 Cr-Commit-Position: refs/heads/master@{#326881}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M remoting/codec/video_encoder_vpx.cc View 1 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Wez
FYI, you need to "Publish+Mail Comments" for an email to get sent to notify reviewers ...
5 years, 8 months ago (2015-04-17 23:57:44 UTC) #2
Wez
https://codereview.chromium.org/1079593004/diff/1/remoting/codec/video_encoder_vpx.cc File remoting/codec/video_encoder_vpx.cc (right): https://codereview.chromium.org/1079593004/diff/1/remoting/codec/video_encoder_vpx.cc#newcode104 remoting/codec/video_encoder_vpx.cc:104: config->rc_target_bitrate = 500; nit: Please add a comment to ...
5 years, 8 months ago (2015-04-18 00:00:23 UTC) #3
aconverse
https://codereview.chromium.org/1079593004/diff/1/remoting/codec/video_encoder_vpx.cc File remoting/codec/video_encoder_vpx.cc (right): https://codereview.chromium.org/1079593004/diff/1/remoting/codec/video_encoder_vpx.cc#newcode104 remoting/codec/video_encoder_vpx.cc:104: config->rc_target_bitrate = 500; On 2015/04/18 00:00:23, Wez wrote: > ...
5 years, 8 months ago (2015-04-20 17:12:27 UTC) #4
Wez
lgtm
5 years, 8 months ago (2015-04-21 01:30:35 UTC) #5
Wez
Please set BUG=134202 in CL description. Let me know if you need me to CQ ...
5 years, 8 months ago (2015-04-21 01:31:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079593004/20001
5 years, 8 months ago (2015-04-24 19:50:12 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 21:38:57 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 21:39:52 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d194235c54b414571f6fbdedf47b00592fbfc690
Cr-Commit-Position: refs/heads/master@{#326881}

Powered by Google App Engine
This is Rietveld 408576698