Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Issue 1079583002: Skip inlines when looking for first-letter layoutObjects. (Closed)

Created:
5 years, 8 months ago by dsinclair
Modified:
5 years, 8 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Skip inlines when looking for first-letter layoutObjects. When looking through the layout tree to determine where to insert a first-letter layoutObject we would stop looking as soon as we saw another layoutObject that specified first-letter. This breaks if you have a block first-letter followed by an inline first-letter as first-letter does not apply to inlines. Make sure that we only stop looking if the layoutObject we've found is not an inline. BUG=464772 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
A LayoutTests/fast/css/first-letter-ignore-inline-style.html View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/first-letter-ignore-inline-style-expected.html View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/dom/FirstLetterPseudoElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
dsinclair
PTAL. This is one way to fix this issue. Another would be to make hasPseudoStyle(FIRST_LETTER) ...
5 years, 8 months ago (2015-04-10 16:57:07 UTC) #2
esprehn
lgtm I'd rather not mess with hasPseudoStyle(). Having the first letter stuff be more self ...
5 years, 8 months ago (2015-04-10 19:44:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079583002/1
5 years, 8 months ago (2015-04-10 20:36:00 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 20:40:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193564

Powered by Google App Engine
This is Rietveld 408576698