Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1079443002: [Telemetry] Add an option to log timestamp. (Closed)

Created:
5 years, 8 months ago by deanliao
Modified:
5 years, 7 months ago
Reviewers:
nednguyen, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Add an option to log timestamp. With "--log_time" optional arg, we can see each logged event's timestamp to know how long does a task spend. BUG=None TEST=manual ./run_benchmark with "-v --log_time" args added. Committed: https://crrev.com/83d444db263917c397f8adeb7040a6b1349c5707 Cr-Commit-Position: refs/heads/master@{#330337}

Patch Set 1 #

Patch Set 2 : Make log timestamp default. Remove the flag. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/telemetry/telemetry/core/browser_options.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
deanliao
With --log_time, we can have a clear picture how long does an action take.
5 years, 8 months ago (2015-04-10 04:50:30 UTC) #2
nednguyen
You'd better off by using python trace by Nat.
5 years, 8 months ago (2015-04-10 16:29:28 UTC) #4
nednguyen
On 2015/04/10 16:29:28, nednguyen wrote: > You'd better off by using python trace by Nat. ...
5 years, 8 months ago (2015-04-10 16:31:45 UTC) #5
deanliao
On 2015/04/10 16:31:45, nednguyen (slow review) wrote: > On 2015/04/10 16:29:28, nednguyen wrote: > > ...
5 years, 7 months ago (2015-05-14 07:37:14 UTC) #6
nednguyen
On 2015/05/14 07:37:14, deanliao wrote: > On 2015/04/10 16:31:45, nednguyen (slow review) wrote: > > ...
5 years, 7 months ago (2015-05-14 16:09:33 UTC) #7
deanliao
On 2015/05/14 16:09:33, nednguyen (slow review) wrote: > On 2015/05/14 07:37:14, deanliao wrote: > > ...
5 years, 7 months ago (2015-05-15 03:31:37 UTC) #8
nednguyen
lgtm
5 years, 7 months ago (2015-05-15 04:29:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079443002/20001
5 years, 7 months ago (2015-05-18 06:41:19 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-18 08:58:28 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:34:03 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/83d444db263917c397f8adeb7040a6b1349c5707
Cr-Commit-Position: refs/heads/master@{#330337}

Powered by Google App Engine
This is Rietveld 408576698