Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1079333002: Require udev for MidiManagerAlsa (Closed)

Created:
5 years, 8 months ago by Adam Goode
Modified:
5 years, 8 months ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@simple-hotplug
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Require udev for MidiManagerAlsa MidiManagerAlsa needs udev for manufacturer extraction and robust device reconnection. Without udev, we cannot reliably get this information from the kernel. This CL is the first step. It puts a hard requirement on udev for MidiManagerAlsa, but doesn't actually do anything useful with it yet. Committed: https://crrev.com/93153e1e9306d5cf9543d38efb403affb89437cd Cr-Commit-Position: refs/heads/master@{#326752}

Patch Set 1 #

Patch Set 2 : Fix whitespace issue #

Patch Set 3 : Rebase to origin/master #

Patch Set 4 : Remove USE_UDEV #

Patch Set 5 : Rebase #

Patch Set 6 : Fix whitespace #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M media/BUILD.gn View 1 2 3 4 5 6 2 chunks +2 lines, -5 lines 0 comments Download
M media/media.gyp View 1 2 3 4 5 2 chunks +6 lines, -1 line 0 comments Download
M media/midi/midi_manager.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M media/midi/midi_manager_alsa.h View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M media/midi/midi_manager_alsa.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M media/midi/midi_manager_unittest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Adam Goode
5 years, 8 months ago (2015-04-23 03:20:34 UTC) #2
Takashi Toyoshima
lgtm. FYI, we will split midi build files to media/midi/midi.gyp and media/midi/BUILD.gn soon. Actually, the ...
5 years, 8 months ago (2015-04-24 04:14:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079333002/100001
5 years, 8 months ago (2015-04-24 04:51:11 UTC) #5
commit-bot: I haz the power
Committed patchset #7 (id:100001)
5 years, 8 months ago (2015-04-24 07:13:49 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 07:14:37 UTC) #7
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/93153e1e9306d5cf9543d38efb403affb89437cd
Cr-Commit-Position: refs/heads/master@{#326752}

Powered by Google App Engine
This is Rietveld 408576698