Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: breakpad/breakpad.gyp

Issue 107933006: Get rid of ui_cocoa_third_party_toolkits target from ui.gyp (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: mark review Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/mac/cocoa_protocols.h ('k') | chrome/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: breakpad/breakpad.gyp
diff --git a/breakpad/breakpad.gyp b/breakpad/breakpad.gyp
index 066bf28d3e2231a961ab7ab39a21d72c14332f3e..4c0b02afc53511bf9f12f4f99beda429541f8b15 100644
--- a/breakpad/breakpad.gyp
+++ b/breakpad/breakpad.gyp
@@ -707,6 +707,9 @@
{
'target_name': 'breakpad_client',
'type': 'static_library',
+ 'dependencies': [
+ '../third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp:google_toolbox_for_mac',
+ ],
'sources': [
'src/client/ios/Breakpad.h',
'src/client/ios/Breakpad.mm',
@@ -756,24 +759,7 @@
'src',
'src/client/mac/Framework',
'src/common/mac',
- # For GTMLogger.
- '<(DEPTH)/third_party/GTM',
- '<(DEPTH)/third_party/GTM/Foundation',
],
- 'link_settings': {
- # Build the version of GTMLogger.m in third_party rather than the
- # one in src/common/mac because the former catches all exceptions
- # whereas the latter lets them propagate, which can cause odd
- # crashes.
- 'sources': [
- '<(DEPTH)/third_party/GTM/Foundation/GTMLogger.h',
- '<(DEPTH)/third_party/GTM/Foundation/GTMLogger.m',
- ],
- 'include_dirs': [
- '<(DEPTH)/third_party/GTM',
- '<(DEPTH)/third_party/GTM/Foundation',
- ],
- },
}
]
}],
« no previous file with comments | « base/mac/cocoa_protocols.h ('k') | chrome/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698