Get rid of ui_cocoa_third_party_toolkits target from ui.gyp

third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp

Index: third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp
diff --git a/third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp b/third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp
new file mode 100644
index 0000000000000000000000000000000000000000..00d015baf404bca3a904d3b6e48951d8f7acfec6
--- /dev/null
+++ b/third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp
@@ -0,0 +1,63 @@
+# Copyright 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+  'targets': [
+    {
+      'target_name': 'google_toolbox_for_mac',
+      'type': '<(component)',
+      'include_dirs': [

[Mark Mentovai, 2013/12/13 23:03:20]

I think you will almost definitely need to also put all of these directories
into a 'direct_dependent_settings': {'include_dirs': […]} block. See my other
comments throughout the review.

[tfarina, 2013/12/16 02:42:03]

Done.

+        '../../third_party/google_toolbox_for_mac',

[Mark Mentovai, 2013/12/13 23:03:20]

You are in third_party/google_toolbox_for_mac. This can just be '.'.

[tfarina, 2013/12/16 02:42:03]

Done.

+        '../../third_party/google_toolbox_for_mac/src',

[Mark Mentovai, 2013/12/13 23:03:20]

And this can just be 'src'. Etc., etc.

[tfarina, 2013/12/16 02:42:03]

Done.

+        '../../third_party/google_toolbox_for_mac/src/AppKit',
+        '../../third_party/google_toolbox_for_mac/src/DebugUtils',
+        '../../third_party/google_toolbox_for_mac/src/Foundation',
+      ],
+      'link_settings': {
+        'libraries': [
+          '$(SDKROOT)/System/Library/Frameworks/Cocoa.framework',
+          '$(SDKROOT)/System/Library/Frameworks/QuartzCore.framework',
+        ],
+      },
+      'sources': [
+        'src/AppKit/GTMFadeTruncatingTextFieldCell.h',

[Mark Mentovai, 2013/12/13 23:03:20]

Since this is its own target now, maybe you just want to list everything, or at
least everything in AppKit, DebugUtils, and Foundation. (I’m taking those names
based on what I see built and included here—lines 11-15 too. There’s also
src/AddressBook, which may also be harmless and useful to someone. If you add
src/AddressBook, don’t forget to add it to the include_dirs too.)

find src/AppKit src/DebugUtils src/Foundation -name '*.[c|cc|h|m|mm]' | sed -e
"s/\(.*\)/        '\1',/"

will format the list of all such files for pasting here.

[tfarina, 2013/12/16 02:42:03]

Done.

+        'src/AppKit/GTMFadeTruncatingTextFieldCell.m',
+        'src/AppKit/GTMIBArray.h',
+        'src/AppKit/GTMIBArray.m',
+        'src/AppKit/GTMKeyValueAnimation.h',
+        'src/AppKit/GTMKeyValueAnimation.m',
+        'src/AppKit/GTMNSAnimation+Duration.h',
+        'src/AppKit/GTMNSAnimation+Duration.m',
+        'src/AppKit/GTMNSBezierPath+CGPath.h',
+        'src/AppKit/GTMNSBezierPath+CGPath.m',
+        'src/AppKit/GTMNSBezierPath+RoundRect.h',
+        'src/AppKit/GTMNSBezierPath+RoundRect.m',
+        'src/AppKit/GTMNSColor+Luminance.m',
+        'src/AppKit/GTMUILocalizer.h',
+        'src/AppKit/GTMUILocalizer.m',
+        'src/AppKit/GTMUILocalizerAndLayoutTweaker.h',
+        'src/AppKit/GTMUILocalizerAndLayoutTweaker.m',
+        'src/Foundation/GTMNSNumber+64Bit.h',
+        'src/Foundation/GTMNSNumber+64Bit.m',
+        'src/Foundation/GTMNSObject+KeyValueObserving.h',
+        'src/Foundation/GTMNSObject+KeyValueObserving.m',
+      ],
+      'conditions': [
+        ['component=="shared_library"',
+          {
+            # GTM is third-party code, so we don't want to add _EXPORT
+            # annotations to it, so build it without -fvisibility=hidden
+            # (else the interface class symbols will be hidden in a 64bit
+            # build). Only do this in a component build, so that the shipping
+            # chrome binary doesn't end up with unnecessarily exported
+            # symbols.
+            'xcode_settings': {
+              'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO',
+            },
+          }
+        ],
+      ],
+    },
+  ],
+}