third_party/google_toolbox_for_mac/README.chromium - Issue 107933006: Get rid of ui_cocoa_third_party_toolkits target from ui.gyp

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/google_toolbox_for_mac/README.chromium

Issue 107933006: Get rid of ui_cocoa_third_party_toolkits target from ui.gyp (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: do not build sqlite and zlib foundation files Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 Name: Google Toolbox for Mac

	2 Short Name: google-toolbox-for-mac

	3 URL: http://code.google.com/p/google-toolbox-for-mac/

	4 Version: 616

	5 Security Critical: Yes

	6 License: Apache 2.0

	7 License File: src/COPYING
	tfarina 2013/12/16 02:42:05 It complains, but the path seems right. Got Lice It complains, but the path seems right. Got LicenseError "License file not found. Either add a file named LICENSE, import upstream's COPYING if available, or add a 'License File:' line to README.chromium with the appropriate path." while scanning third_party/google_toolbox_for_mac http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/13... Mark Mentovai 2013/12/16 23:06:01 src/COPYING is checked out in a deps_os section on src/COPYING is checked out in a deps_os section on Mac only. Is the license checker running on Linux? tfarina 2013/12/16 23:36:41 yep. Show quoted text On 2013/12/16 23:06:01, Mark Mentovai wrote: > src/COPYING is checked out in a deps_os section on Mac only. yep. Show quoted text > Is the license checker running on Linux? yep. The problem seems to be that the directory and thus README.chromium and the gyp file are present in non-mac checkouts. Because they are checked in the source tree rather than being checkout out from upstream. And the license tool scans the directories in third_party, so it finds us on Linux but do not find the src/COPYING.
	8

	9 Description:

	10 A collection of source from different Google projects that may be of use to

	11 developers working other Mac projects.

	12

	13 Local Modifications:

	14 None.

OLD	NEW

« no previous file with comments | « remoting/remoting.gyp ('k') | third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp » ('j') | no next file with comments »