third_party/google_toolbox_for_mac/README.chromium - Issue 107933006: Get rid of ui_cocoa_third_party_toolkits target from ui.gyp

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/google_toolbox_for_mac/README.chromium

Issue 107933006: Get rid of ui_cocoa_third_party_toolkits target from ui.gyp (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ADD README.chromium Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« remoting/remoting.gyp ('K') | « remoting/remoting.gyp ('k') | third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp » ('j') | third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 Name: Google Toolbox for Mac

	2 URL: http://code.google.com/p/google-toolbox-for-mac/

	3 Version: unknown
	Mark Mentovai 2013/12/13 23:03:20 Maybe this should be “see DEPS” or the specific re Maybe this should be “see DEPS” or the specific revision we’re checking out, instead of “unknown.” tfarina 2013/12/16 02:42:03 Done. Show quoted text On 2013/12/13 23:03:20, Mark Mentovai wrote: > Maybe this should be “see DEPS” or the specific revision we’re checking out, > instead of “unknown.” Done.
	4 Security Critical: Yes

	5 License: Apache 2.0
	Mark Mentovai 2013/12/13 23:03:20 See third_party/README.chromium.template The end See third_party/README.chromium.template The end of this file should be like -- License: Apache 2.0 License File: src/COPYING Description: A collection of source from different Google projects that may be of use to developers working other Mac projects. Local Modifications: None. -- I took the description from the GTM project page. README.chromium.template also says to use a “Short Name,” I guess you’d use google-toolbox-for-mac for that based on how I see other README.chromia using that field. tfarina 2013/12/16 02:42:03 Done. Show quoted text On 2013/12/13 23:03:20, Mark Mentovai wrote: > See third_party/README.chromium.template > > The end of this file should be like > > -- > License: Apache 2.0 > License File: src/COPYING > > Description: > > A collection of source from different Google projects that may be of use to > developers working other Mac projects. > > Local Modifications: > > None. > -- > > I took the description from the GTM project page. > > README.chromium.template also says to use a “Short Name,” I guess you’d use > google-toolbox-for-mac for that based on how I see other README.chromia using > that field. Done.
OLD	NEW