Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1957)

Unified Diff: content/child/blink_platform_impl.cc

Issue 1079323002: Support text track selection in video controls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated track menu header to Subtitles Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/app/strings/content_strings.grd ('k') | mojo/services/html_viewer/blink_resource_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/blink_platform_impl.cc
diff --git a/content/child/blink_platform_impl.cc b/content/child/blink_platform_impl.cc
index 8a58c91e89651bb4d01648951fecbf7cc0206996..749ed18bbac3a4a4c378384f0ba2246452d0c93e 100644
--- a/content/child/blink_platform_impl.cc
+++ b/content/child/blink_platform_impl.cc
@@ -405,6 +405,14 @@ static int ToMessageID(WebLocalizedString::Name name) {
return IDS_FORM_INPUT_WEEK_TEMPLATE;
case WebLocalizedString::WeekNumberLabel:
return IDS_FORM_WEEK_NUMBER_LABEL;
+ case WebLocalizedString::TextTracksNoLabel:
+ return IDS_MEDIA_TRACKS_NO_LABEL;
+ case WebLocalizedString::TextTracksOff:
+ return IDS_MEDIA_TRACKS_OFF;
+ case WebLocalizedString::TextTracksSubtitles:
+ return IDS_MEDIA_TRACKS_SUBTITLES;
+ case WebLocalizedString::TextTracksCaptionsMarker:
+ return IDS_MEDIA_TRACKS_CAPTIONS_MARKER;
// This "default:" line exists to avoid compile warnings about enum
// coverage when we add a new symbol to WebLocalizedString.h in WebKit.
// After a planned WebKit patch is landed, we need to add a case statement
@@ -868,6 +876,9 @@ const DataResource kDataResources[] = {
{"mediaplayerOverlayPlay",
IDR_MEDIAPLAYER_OVERLAY_PLAY_BUTTON,
ui::SCALE_FACTOR_100P},
+ {"mediaplayerTrackSelectionCheckmark",
philipj_slow 2015/04/23 13:53:37 Is there a bitmap to go with this too?
philipj_slow 2015/04/23 14:02:45 Oh, it's in https://codereview.chromium.org/108253
+ IDR_MEDIAPLAYER_TRACKSELECTION_CHECKMARK,
+ ui::SCALE_FACTOR_100P},
{"panIcon", IDR_PAN_SCROLL_ICON, ui::SCALE_FACTOR_100P},
{"searchCancel", IDR_SEARCH_CANCEL, ui::SCALE_FACTOR_100P},
{"searchCancelPressed", IDR_SEARCH_CANCEL_PRESSED, ui::SCALE_FACTOR_100P},
« no previous file with comments | « content/app/strings/content_strings.grd ('k') | mojo/services/html_viewer/blink_resource_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698