Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp

Issue 1079323002: Support text track selection in video controls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and lgtm nits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp b/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp
index da562288d7eadb66726660b4ba61fcbcd6cdcf9d..e765bad2961b3bf695500bcc6a6e75828af20944 100644
--- a/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp
@@ -504,7 +504,7 @@ bool MediaControlsPainter::paintMediaToggleClosedCaptionsButton(const LayoutObje
bool isEnabled = mediaElement->hasClosedCaptions();
- if (mediaElement->closedCaptionsVisible())
+ if (mediaElement->textTracksVisible())
return paintMediaButton(paintInfo.context, rect, mediaClosedCaptionButton, isEnabled);
return paintMediaButton(paintInfo.context, rect, mediaClosedCaptionButtonDisabled, isEnabled);
@@ -541,6 +541,39 @@ bool MediaControlsPainter::paintMediaCastButton(const LayoutObject& object, cons
}
}
+bool MediaControlsPainter::paintMediaTrackSelectionCheckmark(const LayoutObject& object, const PaintInfo& paintInfo, const IntRect& rect)
+{
+ const HTMLMediaElement* mediaElement = toParentMediaElement(object);
+ if (!mediaElement)
+ return false;
+
+ static Image* mediaTrackSelectionCheckmark = platformResource("mediaplayerTrackSelectionCheckmark",
+ "mediaplayerTrackSelectionCheckmarkNew");
+ return paintMediaButton(paintInfo.context, rect, mediaTrackSelectionCheckmark);
+}
+
+bool MediaControlsPainter::paintMediaClosedCaptionsIcon(const LayoutObject& object, const PaintInfo& paintInfo, const IntRect& rect)
+{
+ const HTMLMediaElement* mediaElement = toParentMediaElement(object);
+ if (!mediaElement)
+ return false;
+
+ static Image* mediaClosedCaptionsIcon = platformResource("mediaplayerClosedCaptionsIcon",
+ "mediaplayerClosedCaptionsIconNew");
+ return paintMediaButton(paintInfo.context, rect, mediaClosedCaptionsIcon);
+}
+
+bool MediaControlsPainter::paintMediaSubtitlesIcon(const LayoutObject& object, const PaintInfo& paintInfo, const IntRect& rect)
+{
+ const HTMLMediaElement* mediaElement = toParentMediaElement(object);
+ if (!mediaElement)
+ return false;
+
+ static Image* mediaSubtitlesIcon = platformResource("mediaplayerSubtitlesIcon",
+ "mediaplayerSubtitlesIconNew");
+ return paintMediaButton(paintInfo.context, rect, mediaSubtitlesIcon);
+}
+
void MediaControlsPainter::adjustMediaSliderThumbSize(ComputedStyle& style)
{
static Image* mediaSliderThumb = platformResource("mediaplayerSliderThumb",
« no previous file with comments | « third_party/WebKit/Source/core/paint/MediaControlsPainter.h ('k') | third_party/WebKit/Source/core/paint/ThemePainter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698