Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: third_party/WebKit/Source/core/html/track/TextTrack.cpp

Issue 1079323002: Support text track selection in video controls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and lgtm nits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/track/TextTrack.cpp
diff --git a/third_party/WebKit/Source/core/html/track/TextTrack.cpp b/third_party/WebKit/Source/core/html/track/TextTrack.cpp
index 26858a7f9bc763a45be57a13478bd375195e606e..259ac3fe8444458792a82f92fa8fd00b825b5c06 100644
--- a/third_party/WebKit/Source/core/html/track/TextTrack.cpp
+++ b/third_party/WebKit/Source/core/html/track/TextTrack.cpp
@@ -414,7 +414,7 @@ void TextTrack::invalidateTrackIndex()
m_renderedTrackIndex = invalidTrackIndex;
}
-bool TextTrack::isRendered()
+bool TextTrack::isRendered() const
{
if (kind() != captionsKeyword() && kind() != subtitlesKeyword())
return false;
@@ -425,6 +425,18 @@ bool TextTrack::isRendered()
return true;
}
+bool TextTrack::canBeRendered() const
+{
+ // A track can be displayed when it's of kind captions or subtitles and hasn't failed to load.
+ if (kind() != captionsKeyword() && kind() != subtitlesKeyword())
+ return false;
+
+ if (getReadinessState() == FailedToLoad)
+ return false;
+
+ return true;
+}
+
TextTrackCueList* TextTrack::ensureTextTrackCueList()
{
if (!m_cues)

Powered by Google App Engine
This is Rietveld 408576698