Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.h

Issue 1079323002: Support text track selection in video controls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and lgtm nits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.h b/third_party/WebKit/Source/core/html/HTMLMediaElement.h
index da7f4f964d31edb2ff6577cfcd584b3dab5c53e9..a8f5f25ff6954acb6de59f5c2a2144e7e34ee55a 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.h
@@ -203,6 +203,7 @@ public:
void textTrackReadyStateChanged(TextTrack*);
void textTrackModeChanged(TextTrack*);
+ void disableAutomaticTextTrackSelection();
// EventTarget function.
// Both Node (via HTMLElement) and ActiveDOMObject define this method, which
@@ -219,8 +220,7 @@ public:
virtual bool usesOverlayFullscreenVideo() const { return false; }
bool hasClosedCaptions() const;
- bool closedCaptionsVisible() const;
- void setClosedCaptionsVisible(bool);
+ bool textTracksVisible() const;
static void setTextTrackKindUserPreferenceForAllMediaElements(Document*);
void automaticTrackSelectionForUpdatedUserPreference();
@@ -557,9 +557,11 @@ private:
// time has not changed since sending an "ended" event
bool m_sentEndEvent : 1;
- bool m_closedCaptionsVisible : 1;
-
bool m_ignorePreloadNone : 1;
+
+ bool m_textTracksVisible : 1;
+ bool m_shouldPerformAutomaticTrackSelection : 1;
+
bool m_tracksAreReady : 1;
bool m_processingPreferenceChange : 1;
bool m_remoteRoutesAvailable : 1;
« no previous file with comments | « third_party/WebKit/Source/core/css/mediaControlsNew.css ('k') | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698