third_party/WebKit/LayoutTests/media/video-controls-captions-on-off-expected.txt - Issue 1079323002: Support text track selection in video controls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/video-controls-captions-on-off-expected.txt

Issue 1079323002: Support text track selection in video controls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and lgtm nits Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-controls-captions-on-off.html ('k') | third_party/WebKit/LayoutTests/media/video-controls-track-selection-menu.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/video-controls-captions-on-off-expected.txt

diff --git a/third_party/WebKit/LayoutTests/media/video-controls-captions-multiple-clicks-expected.txt b/third_party/WebKit/LayoutTests/media/video-controls-captions-on-off-expected.txt

similarity index 81%

rename from third_party/WebKit/LayoutTests/media/video-controls-captions-multiple-clicks-expected.txt

rename to third_party/WebKit/LayoutTests/media/video-controls-captions-on-off-expected.txt

index 6f42467f2debc205c9f9aae96f1e6de7fc83756e..645fea9dcfdf22a847ed04b9b579ce21ec08f591 100644

--- a/third_party/WebKit/LayoutTests/media/video-controls-captions-multiple-clicks-expected.txt

+++ b/third_party/WebKit/LayoutTests/media/video-controls-captions-on-off-expected.txt

@@ -1,4 +1,4 @@

-Tests that multiple toggles of the closed captions button still display captions

+Tests that tracks can be turned on and off through the track selection menu

EVENT(canplaythrough)

@@ -14,19 +14,19 @@ No text track cue with display id '-webkit-media-text-track-display' is currentl

No text track cue with display id '-webkit-media-text-track-display' is currently visible

-** Captions track should become visible after button is clicked **

+** Captions track should become visible after the track is selected **

*** Click the CC button.

EXPECTED (displayElement.innerText == 'First') OK

EXPECTED (displayElement.innerText == 'Second') OK

EXPECTED (displayElement.innerText == 'Third') OK

-** Captions should not be visible after button is clicked again **

+** Captions should not be visible after they're turned off through the menu **

*** Click the CC button.

No text track cue with display id '-webkit-media-text-track-display' is currently visible

-** Captions should become visible after button is clicked again **

+** Captions track should become visible after the track is selected again **

*** Click the CC button.

EXPECTED (displayElement.innerText == 'First') OK

EXPECTED (displayElement.innerText == 'Second') OK