third_party/WebKit/Source/core/html/shadow/MediaControls.h - Issue 1079323002: Support text track selection in video controls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.h

Issue 1079323002: Support text track selection in video controls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed UX comment on displaying icons only for duplicate labels and rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/shadow/MediaControls.h

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.h b/third_party/WebKit/Source/core/html/shadow/MediaControls.h

index 61e1f693c736941a09793c808be9942947b314b7..e4abf4a51bdcc3d1fd8dc0d837e4f78adb1bff54 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.h

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.h

@@ -59,6 +59,7 @@ public:

void changedClosedCaptionsVisibility();

void refreshClosedCaptionsButtonVisibility();

+ void toggleTextTrackList();

void enteredFullscreen();

void exitedFullscreen();

@@ -141,6 +142,7 @@ private:

Member<MediaControlMuteButtonElement> m_muteButton;

Member<MediaControlVolumeSliderElement> m_volumeSlider;

Member<MediaControlToggleClosedCaptionsButtonElement> m_toggleClosedCaptionsButton;

+ Member<MediaControlTextTrackListElement> m_textTrackList;

Member<MediaControlCastButtonElement> m_castButton;

Member<MediaControlFullscreenButtonElement> m_fullScreenButton;