third_party/WebKit/Source/core/html/track/TextTrack.h - Issue 1079323002: Support text track selection in video controls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/track/TextTrack.h

Issue 1079323002: Support text track selection in video controls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from fs Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/track/TextTrack.h

diff --git a/third_party/WebKit/Source/core/html/track/TextTrack.h b/third_party/WebKit/Source/core/html/track/TextTrack.h

index 31d47947052ca8f6161477f03c964496d6b80cdd..eab55f2daccb9205b1671f0a7218cb4f91c668c9 100644

--- a/third_party/WebKit/Source/core/html/track/TextTrack.h

+++ b/third_party/WebKit/Source/core/html/track/TextTrack.h

@@ -104,6 +104,7 @@ public:

void invalidateTrackIndex();

bool isRendered();

+ bool canBeRendered();

philipj_slow 2016/03/01 13:01:17 Can this not be const? Can you drive-by fix isRend

srivats 2016/03/30 00:46:43 Done.

int trackIndexRelativeToRenderedTracks();

bool hasBeenConfigured() const { return m_hasBeenConfigured; }