Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.h

Issue 1079323002: Support text track selection in video controls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments from fs Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
index 1762f9dea61458c285cff8d6d3561930dc94bcdf..f4ea79e94569e273484615544791d71d1456f8c8 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.h
@@ -34,6 +34,8 @@
namespace blink {
+class TextTrack;
+
// ----------------------------
class MediaControlPanelElement final : public MediaControlDivElement {
@@ -146,6 +148,30 @@ private:
// ----------------------------
+class MediaControlTextTrackListElement final : public MediaControlDivElement {
+public:
+ static PassRefPtrWillBeRawPtr<MediaControlTextTrackListElement> create(MediaControls&);
+
+ bool willRespondToMouseClickEvents() override { return true; }
+
+ void changeVisibility(bool);
philipj_slow 2016/03/01 13:01:16 The meaning of this bool argument isn't obvious, a
srivats 2016/03/30 00:46:43 Changed it to setVisible. I can change it to hide
+
+private:
+ explicit MediaControlTextTrackListElement(MediaControls&);
+
+ void defaultEventHandler(Event*) override;
+
+ void refreshTextTrackListMenu();
+
+ String getTextTrackLabel(TextTrack*);
philipj_slow 2016/03/01 13:01:16 Can you document here and below that null is allow
srivats 2016/03/30 00:46:43 Done.
+ PassRefPtrWillBeRawPtr<Element> createTextTrackListItem(TextTrack*);
+
+ void showTextTrackAtIndex(unsigned);
+ void disableShowingTextTracks();
+};
+
+// ----------------------------
+
class MediaControlTimelineElement final : public MediaControlInputElement {
public:
static PassRefPtrWillBeRawPtr<MediaControlTimelineElement> create(MediaControls&);

Powered by Google App Engine
This is Rietveld 408576698