Support text track selection in video controls

third_party/WebKit/Source/core/css/mediaControlsNew.css

Index: third_party/WebKit/Source/core/css/mediaControlsNew.css
diff --git a/third_party/WebKit/Source/core/css/mediaControlsNew.css b/third_party/WebKit/Source/core/css/mediaControlsNew.css
index 8b82dbf38019b6c79307403fbbbfe9c77a08c65f..5e11e2b8252e8e2c3e5328dac7c4d8beac720059 100644
--- a/third_party/WebKit/Source/core/css/mediaControlsNew.css
+++ b/third_party/WebKit/Source/core/css/mediaControlsNew.css
@@ -44,6 +44,7 @@ video::-webkit-media-controls {
     direction: ltr;
     display: flex;
     flex-direction: column;
+    font-family: Segoe, "Helvetica Neue", Roboto, Arial, Helvetica, sans-serif ;

[philipj_slow, 2016/03/01 13:01:15]

While you're moving this, drop the extra space before the ;

[srivats, 2016/03/30 00:46:42]

Done.

     justify-content: flex-end;
     align-items: center;
 }
@@ -80,7 +81,6 @@ audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel {
     /* The duration is also specified in MediaControlElements.cpp and LayoutTests/media/media-controls.js */
     transition: opacity 0.3s;
 
-    font-family: Segoe, "Helvetica Neue", Roboto, Arial, Helvetica, sans-serif ;
     font-size: 14px;
     font-weight: normal;  /* Make sure that we don't inherit non-defaults. */
     font-style: normal;
@@ -368,6 +368,68 @@ audio::-webkit-media-controls-fullscreen-volume-max-button, video::-webkit-media
     display: none;
 }
 
+video::-internal-media-controls-text-track-list {
+    position: absolute;

[philipj_slow, 2016/03/01 13:01:15]

https://bugs.chromium.org/p/chromium/issues/detail?id=566499 is a bug report
about video controls overlapping things on the page, and the cause appears to be
positioned (position: relative or absolute) elements that change the paint
order. If you know of a simple way to avoid adding new cases of this that would
be good, but if it seems like it'd take a lot of changes to this CL, feel free
to leave it, it's not making matters worse right now.

[srivats, 2016/03/30 00:46:42]

Didn't get a chance to look at this.

+    bottom: 48px;
+    right: 5px;
+    background-color: #fafafa;
+    max-width: 50%;

[philipj_slow, 2016/03/01 13:01:16]

This doesn't seem to be achieving the intended effect, because the width is
limited to 150px even when the video is much wider than 300px and the text
doesn't fit.

[srivats, 2016/03/30 00:46:42]

I am retaining the max-width attribute and I changed min-width to be 150px
instead.

+    max-height: 250px;
+    width: 150px;
+    overflow-x: hidden;
+    overflow-y: auto;
+    text-overflow: ellipsis;

[philipj_slow, 2016/03/01 13:01:15]

Oh look, you're already using text-overflow:ellipsis. But it doesn't seem to
actually work, right? Should be on the item instead, perhaps?

[srivats, 2016/03/30 00:46:42]

Moved it to item and no it still doesn't do ellipsis. :(
The text just gets clipped at the moment.

+    margin-bottom: 5px;
+    white-space: nowrap;
+    font-size: 14px;
+    padding: 8px 0px;
+}
+
+video::-internal-media-controls-text-track-list-item {
+    display: block;
+    color: #424242;
+    text-align: start;
+    line-height: 40px;
+    padding-right: 16px;
+}
+
+video::-internal-media-controls-text-track-list-item:hover {
+    background-color: #e0e0e0;
+}
+
+video::-internal-media-controls-text-track-list-item-input {
+    -webkit-appearance: -internal-media-track-selection-checkmark;
+    position: relative;
+    visibility: hidden;
+    top: -2px;

[philipj_slow, 2016/03/01 13:01:15]

Discussed first in
https://codereview.chromium.org/1082533002/diff/80001/Source/core/css/mediaCo...

Do you mean that if you use a PNG that's just a single color, it will still look
misaligned compared to the text? Does this mean that vertical-align isn't
working as hoped, or why is that?

Fixing this would avoid the position:relative, which would be nice.

[srivats, 2016/03/30 00:46:42]

Removed

+    left: 0;
+    vertical-align: middle;
+    margin: 0 5px 0 0;
+    width: 16px;
+    height: 16px;
+    margin-left: 12px;
+}
+
+video::-internal-media-controls-text-track-list-item-input:checked {
+    visibility: visible;
+}
+
+video::-internal-media-controls-text-track-list-kind-captions {
+    -webkit-appearance: -internal-media-closed-captions-icon;
+    height: 20px;
+    width: 20px;
+    margin-left: 10px;
+    vertical-align: middle;
+}
+
+video::-internal-media-controls-text-track-list-kind-subtitles {
+    -webkit-appearance: -internal-media-subtitles-icon;
+    height: 20px;
+    width: 20px;
+    margin-left: 10px;
+    vertical-align: middle;
+}
+
 video::-webkit-media-text-track-container {
     position: relative;
     width: inherit;