third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h - Issue 1079323002: Support text track selection in video controls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h

Issue 1079323002: Support text track selection in video controls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and addressed fs' comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSValueKeywords.in ('K') | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp » ('j') | third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h b/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h

index 6ee8a71796372af6b173893c6c71045a18316d72..4245fb5e7c4686b05088e5b17fc3643acfad7d86 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h

@@ -48,11 +48,13 @@ enum MediaControlElementType {

MediaSliderThumb,

MediaShowClosedCaptionsButton,

MediaHideClosedCaptionsButton,

+ MediaTextTrackList,

MediaUnMuteButton,

MediaPauseButton,

MediaTimelineContainer,

MediaCurrentTimeDisplay,

MediaTimeRemainingDisplay,

+ MediaTrackSelectionCheckmark,

MediaControlsPanel,

MediaVolumeSliderContainer,

MediaVolumeSlider,

@@ -81,6 +83,8 @@ public:

void setIsWanted(bool);

bool isWanted();

+ bool isHidden();

// Tell us whether we fit or not. This will hide / show the control as

// needed, also.

void setDoesFit(bool);