third_party/WebKit/LayoutTests/media/video-controls-captions.html - Issue 1079323002: Support text track selection in video controls

Unified Diff: third_party/WebKit/LayoutTests/media/video-controls-captions.html

Issue 1079323002: Support text track selection in video controls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and addressed fs' comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-multiple-tracks-expected.txt ('k') | third_party/WebKit/LayoutTests/media/video-controls-captions-expected.txt » ('j') | third_party/WebKit/Source/core/css/CSSValueKeywords.in » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/video-controls-captions.html

diff --git a/third_party/WebKit/LayoutTests/media/video-controls-captions.html b/third_party/WebKit/LayoutTests/media/video-controls-captions.html

index e2251ce899575817b856712766db3650d8201043..71ae2022d8dadef5332e5a921f454399fdd33770 100644

--- a/third_party/WebKit/LayoutTests/media/video-controls-captions.html

+++ b/third_party/WebKit/LayoutTests/media/video-controls-captions.html

@@ -2,7 +2,7 @@

<html>

<head>

- <title>Test closed caption button toggling.</title>

+ <title>Test closed caption track selection functionality.</title>

<!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

@@ -70,21 +70,21 @@

checkCaptionsDisplay();

consoleWrite("");

- consoleWrite("** Captions track should load and captions should become visible after button is clicked **");

+ consoleWrite("** Captions track should load and captions should become visible after a track is selected **");

- // Note: the test flow continues with "testCCButtonToggling" when the

+ // Note: the test flow continues with "testCCTrackSelectionFunctionality" when the

// "load" event of the single TextTrack fires up. While the test structure

// might seem weird, this avoids timeouts.

- clickCCButton();

+ selectTextTrack(video, 0);

}

- function testCCButtonToggling()

+ function testCCTrackSelectionFunctionality()

{

checkCaptionsDisplay();

consoleWrite("");

- consoleWrite("** Captions should not be visible after button is clicked again **");

- clickCCButton();

+ consoleWrite("** Captions should not be visible after Off is clicked **");

+ turnClosedCaptionsOff(video);

checkCaptionsDisplay();

removeHTMLTrackElement();

@@ -94,7 +94,7 @@

testClosedCaptionsButtonVisibility(true);

consoleWrite("");

- clickCCButton();

+ selectTextTrack(video, 0);

}

function trackError()

@@ -118,9 +118,9 @@

</script>

</head>

- <p>Tests that the closed captions button, when toggled, updates the text track display area.</p>

+ <p>Tests that the closed captions button enables track switching</p>

- <track src="track/captions-webvtt/captions-fast.vtt" kind="captions" onload="testCCButtonToggling()">

+ <track src="track/captions-webvtt/captions-fast.vtt" kind="captions" onload="testCCTrackSelectionFunctionality()">

</video>

</body>

</html>