third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-multiple-tracks.html - Issue 1079323002: Support text track selection in video controls

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-multiple-tracks.html

Issue 1079323002: Support text track selection in video controls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge Blink repo changes and addressed comments from philipj and UX Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-add-track.html ('K') | « third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-add-track-expected.txt ('k') | third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-multiple-tracks-expected.txt » ('j') | third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../media-file.js"></script>

	3 <script src="../video-test.js"></script>

	4 <script src="../media-controls.js"></script>

	5 <script>

	6

	7 var trackLanguages = ["en", "ru", "fr", "jp", "de"];

	8 var trackCueText = ["English", "Russian", "French", "Japanese", "German"];

	9

	10 function startTest()

	11 {

	12 findMediaElement();

	13 testClosedCaptionsButtonVisibility(true);

	14 consoleWrite("");

	15 testExpected("video.textTracks.length", trackLanguages.length);

	16 consoleWrite("");

	17

	18 for (var i = 0; i < trackLanguages.length; i++) {

	19 consoleWrite("Select track at index " + i);

	20 selectTextTrack(video, i);

	21 testExpected("video.textTracks[" + i + "].mode", "showing");
	fs 2016/02/23 13:16:43 Check that other tracks are disabled? Check that other tracks are disabled? srivats 2016/02/24 05:20:16 Done. Show quoted text On 2016/02/23 13:16:43, fs wrote: > Check that other tracks are disabled? Done.
	22 testExpected("textTrackDisplayElement(video, 'display').innerText", trackCueText[i]);

	23 consoleWrite("");

	24 }

	25 endTest();

	26 }

	27

	28 function addTextTracks()

	29 {

	30 for (var i = 0; i < trackLanguages.length; i++) {

	31 var track = video.addTextTrack("captions", trackCueText[i], trackLan guages[i]);

	32 track.addCue(new VTTCue(0.0, 1.0, trackCueText[i]));

	33 track.mode = "hidden";
	fs 2016/02/23 13:16:43 'hidden' is the default. 'hidden' is the default. srivats 2016/02/24 05:20:16 Changed it to disabled so I can perform the disabl Show quoted text On 2016/02/23 13:16:43, fs wrote: > 'hidden' is the default. Changed it to disabled so I can perform the disabled check in your above comment.
	34 }

	35 startTest();

	36 }

	37

	38 window.onload = function()

	39 {

	40 consoleWrite("Test that we can add multiple tracks and select between th em from the track selection menu");

	41 findMediaElement();

	42 video.src = findMediaFile("video", "../content/test");

	43 waitForEvent("canplaythrough", addTextTracks);

	44 }

	45

	46 </script>

	47 <video controls></video>

OLD	NEW