third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-add-track.html - Issue 1079323002: Support text track selection in video controls

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-add-track.html

Issue 1079323002: Support text track selection in video controls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge Blink repo changes and addressed comments from philipj and UX Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/media/media-controls.js ('K') | « third_party/WebKit/LayoutTests/media/track/cue-style-invalidation-expected.txt ('k') | third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-add-track-expected.txt » ('j') | third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-multiple-tracks.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../media-file.js"></script>

	3 <script src="../video-test.js"></script>

	4 <script src="../media-controls.js"></script>

	5 <script>

	6

	7 var track;

	8 var trackCueText = "Bonjour";

	9

	10 function selectTrackAdded()

	11 {

	12 findMediaElement();

	13 testClosedCaptionsButtonVisibility(true);

	14 consoleWrite("");

	15 testExpected("video.textTracks.length", 2);

	16 testExpected("video.textTracks[0].mode", "showing");

	17 testExpected("track.mode", "hidden");
	fs 2016/02/23 13:16:43 Using the longer expression "video.textTracks[1].m Using the longer expression "video.textTracks[1].mode" here might make sense. Similarly below (then you don't need to put \|track\| on the global object.) srivats 2016/02/24 05:20:16 Done. Show quoted text On 2016/02/23 13:16:43, fs wrote: > Using the longer expression "video.textTracks[1].mode" here might make sense. > Similarly below (then you don't need to put \|track\| on the global object.) Done.
	18

	19 consoleWrite("");

	20 consoleWrite("Verify the default track is being displayed");

	21 testExpected("textTrackDisplayElement(video, 'display').innerText", "Lor em");

	22

	23 consoleWrite("");

	24 consoleWrite("Select the newly added track");

	25 selectTextTrack(video, 1);

	26 testExpected("track.mode", "showing");
	fs 2016/02/23 13:16:43 Verify that [0] is now 'disabled' too? Verify that [0] is now 'disabled' too? srivats 2016/02/24 05:20:16 Done. Show quoted text On 2016/02/23 13:16:43, fs wrote: > Verify that [0] is now 'disabled' too? Done.
	27 testExpected("textTrackDisplayElement(video, 'display').innerText", trac kCueText);

	28 endTest();

	29 }

	30

	31 function addTextTrack()

	32 {

	33 track = video.addTextTrack("captions", "French", "fr");

	34 track.addCue(new VTTCue(0.0, 1.0, trackCueText));

	35 track.mode = "hidden";
	fs 2016/02/23 13:16:43 'hidden' is the default in this case. 'hidden' is the default in this case. srivats 2016/02/24 05:20:16 Done. Show quoted text On 2016/02/23 13:16:43, fs wrote: > 'hidden' is the default in this case. Done.
	36 selectTrackAdded();

	37 }

	38

	39 window.onload = function()

	40 {

	41 consoleWrite("Test that we can add a track dynamically and it is display ed on the track selection menu");

	42 findMediaElement();

	43 video.src = findMediaFile("video", "../content/test");

	44 waitForEvent("canplaythrough", addTextTrack);

	45 }

	46

	47 </script>

	48 <video controls>

	49 <track src="captions-webvtt/captions.vtt" kind="captions" label="English" sr clang="en" default>

	50 </video>

OLD	NEW