third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-add-track.html - Issue 1079323002: Support text track selection in video controls

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-add-track.html

Issue 1079323002: Support text track selection in video controls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from fs Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/app/strings/content_strings.grd ('K') | « third_party/WebKit/LayoutTests/media/track/cue-style-invalidation-expected.txt ('k') | third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-add-track-expected.txt » ('j') | third_party/WebKit/Source/core/css/mediaControls.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../media-file.js"></script>

	3 <script src="../video-test.js"></script>
	philipj_slow 2016/03/01 09:08:27 In the new tests that use video-test.js, can you a In the new tests that use video-test.js, can you add TODOs like I've recently added everywhere else? <!-- TODO(srivats): Convert test to testharness.js. crbug.com/588956 (Please avoid writing new tests using video-test.js) --> It looks like you don't use much of the video-test.js framework, so it should be pretty easy to rewrite, but not in this CL, it's been in-progress for so long already :) srivats 2016/03/30 00:46:42 Of course. Added Show quoted text On 2016/03/01 09:08:27, philipj_UTC7 wrote: > In the new tests that use video-test.js, can you add TODOs like I've recently > added everywhere else? > > <!-- TODO(srivats): Convert test to testharness.js. crbug.com/588956 > (Please avoid writing new tests using video-test.js) --> > > It looks like you don't use much of the video-test.js framework, so it should be > pretty easy to rewrite, but not in this CL, it's been in-progress for so long > already :) Of course. Added
	4 <script src="../media-controls.js"></script>

	5 <script>

	6

	7 var trackCueText = "Bonjour";

	8

	9 function selectTrackAdded()

	10 {

	11 findMediaElement();

	12 testClosedCaptionsButtonVisibility(true);

	13 consoleWrite("");

	14 testExpected("video.textTracks.length", 2);

	15 testExpected("video.textTracks[0].mode", "showing");

	16 testExpected("video.textTracks[1].mode", "hidden");

	17

	18 consoleWrite("");

	19 consoleWrite("Verify the default track is being displayed");

	20 testExpected("textTrackDisplayElement(video, 'display').innerText", "Lor em");

	21

	22 consoleWrite("");

	23 consoleWrite("Select the newly added track");

	24 selectTextTrack(video, 1);

	25 testExpected("video.textTracks[1].mode", "showing");

	26 testExpected("video.textTracks[0].mode", "disabled");

	27 testExpected("textTrackDisplayElement(video, 'display').innerText", trac kCueText);

	28 endTest();

	29 }

	30

	31 function addTextTrack()

	32 {

	33 track = video.addTextTrack("captions", "French", "fr");

	34 track.addCue(new VTTCue(0.0, 1.0, trackCueText));

	35 selectTrackAdded();

	36 }

	37

	38 window.onload = function()

	39 {

	40 consoleWrite("Test that we can add a track dynamically and it is display ed on the track selection menu");

	41 findMediaElement();

	42 video.src = findMediaFile("video", "../content/test");

	43 waitForEvent("canplaythrough", addTextTrack);

	44 }

	45

	46 </script>

	47 <video controls>

	48 <track src="captions-webvtt/captions.vtt" kind="captions" label="English" sr clang="en" default>

	49 </video>

OLD	NEW