Support text track selection in video controls

third_party/WebKit/Source/core/html/track/TextTrack.cpp

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2011, 2012, 2013 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 407 matching lines @@
 {
     if (kind() != captionsKeyword() && kind() != subtitlesKeyword())
         return false;
 
     if (m_mode != showingKeyword())
         return false;
 
     return true;
 }
 
+bool TextTrack::canBeRendered()
+{
+    // A track can be displayed when it's of kind captions or subtitles and hasn't failed to load.
+    if ((kind() == captionsKeyword() || kind() == subtitlesKeyword()) && readinessState() != FailedToLoad)

[fs, 2016/02/24 10:14:57]

Could you write this like:

if (kind() != captionsKeyword() && kind() != subtitlesKeyword())
    return false;
if (readinessState() == FailedToLoad)
    return false;
return true;

instead?

[srivats, 2016/02/25 21:47:56]

Done.

+        return true;
+    return false;
+}
+
 TextTrackCueList* TextTrack::ensureTextTrackCueList()
 {
     if (!m_cues)
         m_cues = TextTrackCueList::create();
 
     return m_cues.get();
 }
 
 int TextTrack::trackIndexRelativeToRenderedTracks()
 {
@@ skipping 35 matching lines @@
 {
     visitor->trace(m_cues);
     visitor->trace(m_activeCues);
     visitor->trace(m_regions);
     visitor->trace(m_trackList);
     TrackBase::trace(visitor);
     RefCountedGarbageCollectedEventTargetWithInlineData<TextTrack>::trace(visitor);
 }
 
 } // namespace blink