Issue 10793: More assertion propagation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10793: More assertion propagation. (Closed)

Created:
12 years ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Fixed some assertion propagation issues and added non-multiline $ propagation.

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+145 lines, -87 lines)			Patch
M	src/jsregexp.h	View	9 chunks	+58 lines, -22 lines	0 comments	Download
M	src/jsregexp.cc	View	11 chunks	+63 lines, -37 lines	0 comments	Download
M	src/parser.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/parser.cc	View	4 chunks	+11 lines, -9 lines	1 comment	Download
M	test/cctest/test-regexp.cc	View	7 chunks	+10 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

12 years ago (2008-11-27 10:30:05 UTC) #2

LGTM

http://codereview.chromium.org/10793/diff/1/4
File src/parser.cc (right):

http://codereview.chromium.org/10793/diff/1/4#newcode4301
Line 4301: // TODO(plesner): Get multiline flag somehow
out of date comment

Expand Messages | Collapse Messages