Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: content/browser/frame_host/frame_tree_node.cc

Issue 1079163008: PlzNavigate: provide the FrameTreeNode ID to the network stack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-unittests
Patch Set: Now using FTN id or routing ID Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/frame_tree_node.cc
diff --git a/content/browser/frame_host/frame_tree_node.cc b/content/browser/frame_host/frame_tree_node.cc
index 15679805e80deb41c13d12ad670af4db0ea014df..7a1ed1ce731dd3b2bd4d77273e5cbd1778d6016c 100644
--- a/content/browser/frame_host/frame_tree_node.cc
+++ b/content/browser/frame_host/frame_tree_node.cc
@@ -180,6 +180,7 @@ void FrameTreeNode::SetNavigationRequest(
CHECK(base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableBrowserSideNavigation));
ResetNavigationRequest(false);
+ DidStartLoading(true);
nasko 2015/04/27 14:24:11 Does that and the DidStopLoading code fix issues o
clamy 2015/04/27 14:34:44 No this was a test patch that I uploaded and was r
// TODO(clamy): perform the StartLoading logic here.
navigation_request_ = navigation_request.Pass();
}
@@ -192,6 +193,7 @@ void FrameTreeNode::ResetNavigationRequest(bool is_commit) {
// corresponds to a cancelation, the RenderFrameHostManager should clean up
// any speculative RenderFrameHost it created for the navigation.
if (navigation_request_ && !is_commit) {
+ DidStopLoading();
// TODO(clamy): perform the StopLoading logic.
render_manager_.CleanUpNavigation();
}

Powered by Google App Engine
This is Rietveld 408576698