Now component extension (v1): unregister from GCM on startup

Now component extension (v1): unregister from GCM on startup

BUG=479274
Committed: https://crrev.com/e5499ddebc7499f765ef3688d8c4c293ee3138cf
Cr-Commit-Position: refs/heads/master@{#326696}

[skare_, 2015-04-23 21:46:46]

skare@chromium.org changed reviewers:
+ robliao@chromium.org

[skare_, 2015-04-23 22:08:13]

On 2015/04/23 22:06:14, skare_ wrote:

the diff with signing in again is https://codereview.chromium.org/1071393005
(testing)

[robliao, 2015-04-23 22:10:09]

lgtm

[skare_, 2015-04-23 22:20:28]

The CQ bit was checked by skare@chromium.org

[commit-bot: I haz the power, 2015-04-23 22:21:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079163004/20001

[skare_, 2015-04-23 22:35:06]

+cc fgorski/zea

[fgorski, 2015-04-23 22:38:37]

fgorski@chromium.org changed reviewers:
+ fgorski@chromium.org

[fgorski, 2015-04-23 22:38:37]

https://codereview.chromium.org/1079163004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/1079163004/diff/20001/chrome/browser/resource...
chrome/browser/resources/google_now/background.js:1325:
instrumented.gcm.unregister(function() {});
Would it make sense to call chrome.storage.local.remove() after successful
unregistration? that way you make sure you really unregister.

If the unregistration fails (perhaps there is no network), you will still be
making GCM connections, with no way of knowing that you are registered.

[skare_, 2015-04-23 22:44:38]

The CQ bit was unchecked by skare@chromium.org

[skare_, 2015-04-23 22:50:53]

https://codereview.chromium.org/1079163004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/google_now/background.js (right):

https://codereview.chromium.org/1079163004/diff/20001/chrome/browser/resource...
chrome/browser/resources/google_now/background.js:1325:
instrumented.gcm.unregister(function() {});
On 2015/04/23 22:38:37, fgorski wrote:
> Would it make sense to call chrome.storage.local.remove() after successful
> unregistration? that way you make sure you really unregister.
> 
> If the unregistration fails (perhaps there is no network), you will still be
> making GCM connections, with no way of knowing that you are registered.

uploaded new snapshot -- via if(!chrome.runtime.lastError){clearStorage()} in
the gcm.unregister callback?

[fgorski, 2015-04-23 23:02:03]

lgtm, this should do it

[skare_, 2015-04-23 23:38:17]

The CQ bit was checked by skare@chromium.org

[skare_, 2015-04-23 23:38:17]

The patchset sent to the CQ was uploaded after l-g-t-m from robliao@chromium.org
Link to the patchset: https://codereview.chromium.org/1079163004/#ps40001
(title: "Unregister before clearing storage")

[commit-bot: I haz the power, 2015-04-23 23:38:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079163004/40001

[commit-bot: I haz the power, 2015-04-24 00:11:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-24 00:12:07]

Patchset 3 (id:??) landed as
https://crrev.com/e5499ddebc7499f765ef3688d8c4c293ee3138cf
Cr-Commit-Position: refs/heads/master@{#326696}