Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: build/android/pylib/screenshot.py

Issue 1079113002: [Android] Add a "quiet" flag so KillAll doesn't complain if no processes killed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update pylib/screenshot.py Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/screenshot.py
diff --git a/build/android/pylib/screenshot.py b/build/android/pylib/screenshot.py
index ea939b704ce6fd51fc0f70aac82a86af46cb66f2..b5f2c65acb8578b9535440595227268b5067e945 100644
--- a/build/android/pylib/screenshot.py
+++ b/build/android/pylib/screenshot.py
@@ -73,9 +73,8 @@ class VideoRecorder(object):
self._is_started = False
if not self._recorder:
return
- try:
- self._device.KillAll('screenrecord', signum=signal.SIGINT)
- except device_errors.CommandFailedError:
+ if not self._device.KillAll('screenrecord', signum=signal.SIGINT,
+ quiet=True):
logging.warning('Nothing to kill: screenrecord was not running')
self._recorder.wait()

Powered by Google App Engine
This is Rietveld 408576698