Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: tools/telemetry/telemetry/core/platform/android_platform_backend.py

Issue 1079113002: [Android] Add a "quiet" flag so KillAll doesn't complain if no processes killed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix typo Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/screenshot.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/platform/android_platform_backend.py
diff --git a/tools/telemetry/telemetry/core/platform/android_platform_backend.py b/tools/telemetry/telemetry/core/platform/android_platform_backend.py
index e03246023809a1b9a3947d75002355b8c141aa13..360dbbf5890c0b133d5d86b26c7230bafca6c970 100644
--- a/tools/telemetry/telemetry/core/platform/android_platform_backend.py
+++ b/tools/telemetry/telemetry/core/platform/android_platform_backend.py
@@ -262,17 +262,14 @@ class AndroidPlatformBackend(
self._device.ForceStop(application)
def KillApplication(self, application):
- """Kill the given application.
+ """Kill the given |application|.
+
+ Might be used instead of ForceStop for efficiency reasons.
Args:
application: The full package name string of the application to kill.
"""
- # We use KillAll rather than ForceStop for efficiency reasons.
- try:
- self._adb.device().KillAll(application, retries=0)
- time.sleep(3)
- except device_errors.CommandFailedError:
- pass
+ self._device.KillAll(application, blocking=True, quiet=True)
def LaunchApplication(
self, application, parameters=None, elevate_privilege=False):
« no previous file with comments | « build/android/pylib/screenshot.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698