build/android/pylib/gtest/local_device_gtest_run.py - Issue 1079113002: [Android] Add a "quiet" flag so KillAll doesn't complain if no processes killed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/local_device_gtest_run.py

Issue 1079113002: [Android] Add a "quiet" flag so KillAll doesn't complain if no processes killed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typo Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/gtest/local_device_gtest_run.py

diff --git a/build/android/pylib/gtest/local_device_gtest_run.py b/build/android/pylib/gtest/local_device_gtest_run.py

index c48c8659ed9672049c0260336ea372be86743169..ff12d82ad9c8c2900c56365b431aae9c717c61c4 100644

--- a/build/android/pylib/gtest/local_device_gtest_run.py

+++ b/build/android/pylib/gtest/local_device_gtest_run.py

@@ -112,12 +112,7 @@ class _ExeDelegate(object):

return output

def Clear(self, device):

- try:

- device.KillAll(self._exe_file_name, blocking=True, timeout=30, retries=0)

- except device_errors.CommandFailedError:

- # Raised if there is no process with the given name, which in this case

- # is all we care about.

- pass

+ device.KillAll(self._exe_file_name, blocking=True, timeout=30, quiet=True)

class LocalDeviceGtestRun(local_device_test_run.LocalDeviceTestRun):

« no previous file with comments | « build/android/pylib/device_signal.py ('k') | build/android/pylib/gtest/test_package_exe.py » ('j') | no next file with comments »