Issue 10791: Added select all text functionality after pressing ESC ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10791: Added select all text functionality after pressing ESC ... (Closed)

Created:
12 years ago by Mohamed Mansour (USE mhm)

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting, M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Added select all text functionality after pressing ESC on omnibox when has focus BUG=4203

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_edit.cc	View	1	1 chunk	+4 lines, -2 lines	1 comment	Download

Total messages: 5 (0 generated)

Mohamed Mansour (USE mhm)

I have fixed this bug and would like someone to review it for me. Just ...

12 years ago (2008-11-27 03:34:35 UTC) #1

M-A Ruel

It looks good to me with a dot at the end of the comment. Please ...

12 years ago (2008-11-27 14:38:32 UTC) #2

Mohamed Mansour (USE mhm)

Okay, submitted the fix to http://codereview.chromium.org/10791

12 years ago (2008-11-27 23:15:03 UTC) #3

Peter Kasting

This change is fine as far as it goes, but I think it does not ...

12 years ago (2008-11-27 23:36:20 UTC) #4

Mohamed Mansour (USE mhm)

12 years ago (2008-11-28 01:36:08 UTC) #5

Okay, submitted the update http://codereview.chromium.org/10800