Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1079083003: Fix gn_all deps when enable_configuration_policy=false (Closed)

Created:
5 years, 8 months ago by Tomasz Moniuszko
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gn_all deps when enable_configuration_policy=false BUG= Committed: https://crrev.com/e5578b92aef9a713eb01481463c5dcf74e2556e9 Cr-Commit-Position: refs/heads/master@{#325018}

Patch Set 1 #

Patch Set 2 : Rebase onto latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M BUILD.gn View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Tomasz Moniuszko
5 years, 8 months ago (2015-04-10 10:28:06 UTC) #2
brettw
lgtm
5 years, 8 months ago (2015-04-10 17:58:43 UTC) #3
Dirk Pranke
What configuration needs to set this to false, and why? It seems like all of ...
5 years, 8 months ago (2015-04-10 18:09:44 UTC) #4
Tomasz Moniuszko
On 2015/04/10 18:09:44, Dirk Pranke wrote: > What configuration needs to set this to false, ...
5 years, 8 months ago (2015-04-13 08:44:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079083003/1
5 years, 8 months ago (2015-04-14 07:46:59 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/42563) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-14 07:51:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1079083003/20001
5 years, 8 months ago (2015-04-14 08:53:55 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-14 09:38:13 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 09:39:18 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5578b92aef9a713eb01481463c5dcf74e2556e9
Cr-Commit-Position: refs/heads/master@{#325018}

Powered by Google App Engine
This is Rietveld 408576698