[cros New-GAIA] Webview login and new GAIA endpoint enabled by default

[cros New-GAIA] Webview login and new GAIA endpoint enabled by default

For devices with Remora/Shark requisition webview is still disabled (http://crbug.com/464049)

webview is disabled for these tests:
* WizardControllerProxyAuthOnSigninTest* (http://crbug.com/452452)
* ProxyAuthOnUserBoardScreenTest* (http://crbug.com/452452)
* Tests that are based on LoginManagerTest/OobeBaseTest and are not yet parametrized (http://crbug.com/477402)

BUG=475529, 452452, 472664, 464049, 477402
TBR=jhawkins@chromium.org

Committed: https://crrev.com/29061783f8b59f1e78286a87a3bb7d18129f639a
Cr-Commit-Position: refs/heads/master@{#325307}

[Nikita (slow), 2015-04-10 10:29:09]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-10 10:29:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079083002/20001

[commit-bot: I haz the power, 2015-04-10 10:36:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-10 10:36:55]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nikita (slow), 2015-04-10 11:14:23]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-10 11:14:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079083002/40001

[commit-bot: I haz the power, 2015-04-10 11:22:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-10 11:22:36]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nikita (slow), 2015-04-10 14:02:46]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-10 14:03:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079083002/60001

[Nikita (slow), 2015-04-10 15:38:17]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-10 15:38:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079083002/80001

[commit-bot: I haz the power, 2015-04-10 15:48:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-10 15:48:10]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nikita (slow), 2015-04-13 10:06:35]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-13 10:07:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079083002/120001

[commit-bot: I haz the power, 2015-04-13 10:14:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-13 10:14:15]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nikita (slow), 2015-04-13 16:05:03]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-13 16:05:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079083002/140001

[commit-bot: I haz the power, 2015-04-13 16:15:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-13 16:15:24]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nikita (slow), 2015-04-14 10:41:11]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-14 10:41:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079083002/160001

[commit-bot: I haz the power, 2015-04-14 10:50:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-14 10:50:16]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nikita (slow), 2015-04-14 11:37:58]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-14 11:38:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079083002/180001

[commit-bot: I haz the power, 2015-04-14 11:45:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-14 11:45:51]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nikita (slow), 2015-04-14 12:29:48]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-14 12:30:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079083002/200001

[commit-bot: I haz the power, 2015-04-14 12:38:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-14 12:38:58]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nikita (slow), 2015-04-14 14:17:17]

Patchset #13 (id:240001) has been deleted

[Nikita (slow), 2015-04-14 18:44:25]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-14 18:44:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079083002/300001

[commit-bot: I haz the power, 2015-04-14 18:55:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-14 18:55:17]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nikita (slow), 2015-04-15 11:48:38]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-15 11:49:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079083002/320001

[commit-bot: I haz the power, 2015-04-15 11:57:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-15 11:57:42]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nikita (slow), 2015-04-15 11:59:08]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-15 11:59:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079083002/340001

[commit-bot: I haz the power, 2015-04-15 12:08:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-15 12:08:18]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nikita (slow), 2015-04-15 14:42:10]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-15 14:42:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079083002/360001

[commit-bot: I haz the power, 2015-04-15 14:52:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-15 14:52:03]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nikita (slow), 2015-04-15 15:07:14]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-15 15:07:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079083002/400001

[Nikita (slow), 2015-04-15 15:09:44]

nkostylev@chromium.org changed reviewers:
+ dzhioev@chromium.org

[Nikita (slow), 2015-04-15 15:09:45]

Pavel, please review.

This CL is ready for review, all tests now have either two versions for webview
/ iframe or default to iframe version.

I'll file a bug to track fixing those tests for webview so that this CL is not
blocked.

[commit-bot: I haz the power, 2015-04-15 15:15:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-15 15:15:58]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nikita (slow), 2015-04-15 17:23:25]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-15 17:23:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079083002/420001

[commit-bot: I haz the power, 2015-04-15 17:35:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-15 17:35:36]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dzhioev (left Google), 2015-04-15 17:36:25]

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/helper.cc (right):

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
chrome/browser/chromeos/login/helper.cc:161: if (!signin_partition &&
!LoginDisplayHostImpl::default_host())
Please try to return nullptr in this case. Or at least check that we are in unit
test.

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/hid_detection_browsertest.cc (right):

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
chrome/browser/chromeos/login/hid_detection_browsertest.cc:52: use_webview_ =
GetParam();
Create setter.

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/oobe_browsertest.cc (right):

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
chrome/browser/chromeos/login/oobe_browsertest.cc:35: const char
kFakeLSIDCookie[] = "fake-LSID-cookie";
What this cookies are needed for? I see that we set the same cookies in
WebviewLoginTest . Should we move them to base test?

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/test/oobe_base_test.cc (right):

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
chrome/browser/chromeos/login/test/oobe_base_test.cc:240:
ASSERT_TRUE(message_queue.WaitForMessage(&message));
Please check message's value in loop, until you receive \"GaiaReady\"

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/wizard_controller_browsertest.cc (right):

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
chrome/browser/chromeos/login/wizard_controller_browsertest.cc:973: public
testing::WithParamInterface<bool> {
nit: please put a comment here on the parameter meaning.
+ other tests, where you added params

[Nikita (slow), 2015-04-15 18:35:42]

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/helper.cc (right):

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
chrome/browser/chromeos/login/helper.cc:161: if (!signin_partition &&
!LoginDisplayHostImpl::default_host())
On 2015/04/15 17:36:24, dzhioev wrote:
> Please try to return nullptr in this case. Or at least check that we are in
unit
> test.

Returning nullptr here wouldn't work as UserCloudPolicyManagerChromeOS expects
to get something to fetch tokens it needs (in tests). I've added TODO and a bug.

Another unclear thing to me right now is whether this codepath gets hit when
browser gets restarted after crash and there's no webview instance as well. I'll
investigate that too just not in this CL.

So the plan is to enable this by default one month before branch to see what
breaks.

I'll file a separate bug for enterprise team to investigate.

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/hid_detection_browsertest.cc (right):

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
chrome/browser/chromeos/login/hid_detection_browsertest.cc:52: use_webview_ =
GetParam();
On 2015/04/15 17:36:25, dzhioev wrote:
> Create setter.

Done.

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/oobe_browsertest.cc (right):

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
chrome/browser/chromeos/login/oobe_browsertest.cc:35: const char
kFakeLSIDCookie[] = "fake-LSID-cookie";
On 2015/04/15 17:36:25, dzhioev wrote:
> What this cookies are needed for? I see that we set the same cookies in
> WebviewLoginTest . Should we move them to base test?

Done.

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/test/oobe_base_test.cc (right):

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
chrome/browser/chromeos/login/test/oobe_base_test.cc:240:
ASSERT_TRUE(message_queue.WaitForMessage(&message));
On 2015/04/15 17:36:25, dzhioev wrote:
> Please check message's value in loop, until you receive \"GaiaReady\"

Done.

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/wizard_controller_browsertest.cc (right):

https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
chrome/browser/chromeos/login/wizard_controller_browsertest.cc:973: public
testing::WithParamInterface<bool> {
On 2015/04/15 17:36:25, dzhioev wrote:
> nit: please put a comment here on the parameter meaning.
> + other tests, where you added params

Done.

[Nikita (slow), 2015-04-15 18:38:26]

The CQ bit was checked by nkostylev@chromium.org to run a CQ dry run

[dzhioev (left Google), 2015-04-15 18:39:13]

On 2015/04/15 18:35:42, Nikita Kostylev wrote:
>
https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
> File chrome/browser/chromeos/login/helper.cc (right):
> 
>
https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
> chrome/browser/chromeos/login/helper.cc:161: if (!signin_partition &&
> !LoginDisplayHostImpl::default_host())
> On 2015/04/15 17:36:24, dzhioev wrote:
> > Please try to return nullptr in this case. Or at least check that we are in
> unit
> > test.
> 
> Returning nullptr here wouldn't work as UserCloudPolicyManagerChromeOS expects
> to get something to fetch tokens it needs (in tests). I've added TODO and a
bug.
> 
> Another unclear thing to me right now is whether this codepath gets hit when
> browser gets restarted after crash and there's no webview instance as well.
I'll
> investigate that too just not in this CL.
> 
> So the plan is to enable this by default one month before branch to see what
> breaks.
> 
> I'll file a separate bug for enterprise team to investigate.
> 
>
https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
> File chrome/browser/chromeos/login/hid_detection_browsertest.cc (right):
> 
>
https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
> chrome/browser/chromeos/login/hid_detection_browsertest.cc:52: use_webview_ =
> GetParam();
> On 2015/04/15 17:36:25, dzhioev wrote:
> > Create setter.
> 
> Done.
> 
>
https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
> File chrome/browser/chromeos/login/oobe_browsertest.cc (right):
> 
>
https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
> chrome/browser/chromeos/login/oobe_browsertest.cc:35: const char
> kFakeLSIDCookie[] = "fake-LSID-cookie";
> On 2015/04/15 17:36:25, dzhioev wrote:
> > What this cookies are needed for? I see that we set the same cookies in
> > WebviewLoginTest . Should we move them to base test?
> 
> Done.
> 
>
https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
> File chrome/browser/chromeos/login/test/oobe_base_test.cc (right):
> 
>
https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
> chrome/browser/chromeos/login/test/oobe_base_test.cc:240:
> ASSERT_TRUE(message_queue.WaitForMessage(&message));
> On 2015/04/15 17:36:25, dzhioev wrote:
> > Please check message's value in loop, until you receive \"GaiaReady\"
> 
> Done.
> 
>
https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
> File chrome/browser/chromeos/login/wizard_controller_browsertest.cc (right):
> 
>
https://codereview.chromium.org/1079083002/diff/400001/chrome/browser/chromeo...
> chrome/browser/chromeos/login/wizard_controller_browsertest.cc:973: public
> testing::WithParamInterface<bool> {
> On 2015/04/15 17:36:25, dzhioev wrote:
> > nit: please put a comment here on the parameter meaning.
> > + other tests, where you added params
> 
> Done.

LGTM

[commit-bot: I haz the power, 2015-04-15 18:39:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079083002/440001

[Nikita (slow), 2015-04-15 18:44:53]

TBR jhawkins@ for
chrome/interactive_ui_tests.isolate

[Nikita (slow), 2015-04-15 18:45:12]

The CQ bit was unchecked by nkostylev@chromium.org

[Nikita (slow), 2015-04-15 18:45:35]

The CQ bit was checked by nkostylev@chromium.org

[commit-bot: I haz the power, 2015-04-15 18:45:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079083002/440001

[Nikita (slow), 2015-04-15 18:57:15]

The CQ bit was checked by nkostylev@chromium.org

[Nikita (slow), 2015-04-15 18:57:16]

The patchset sent to the CQ was uploaded after l-g-t-m from dzhioev@chromium.org
Link to the patchset: https://codereview.chromium.org/1079083002/#ps460001
(title: "fix compile")

[Nikita (slow), 2015-04-15 18:57:30]

nkostylev@chromium.org changed reviewers:
+ jhawkins@chromium.org

[Nikita (slow), 2015-04-15 18:57:46]

TBR jhawkins@ for
chrome/interactive_ui_tests.isolate

[commit-bot: I haz the power, 2015-04-15 18:58:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079083002/460001

[Nikita (slow), 2015-04-15 19:45:02]

The CQ bit was unchecked by nkostylev@chromium.org

[Nikita (slow), 2015-04-15 19:59:59]

The CQ bit was checked by nkostylev@chromium.org

[Nikita (slow), 2015-04-15 20:00:00]

The patchset sent to the CQ was uploaded after l-g-t-m from dzhioev@chromium.org
Link to the patchset: https://codereview.chromium.org/1079083002/#ps480001
(title: "fix saml test")

[commit-bot: I haz the power, 2015-04-15 20:00:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1079083002/480001

[commit-bot: I haz the power, 2015-04-15 21:19:28]

Committed patchset #24 (id:480001)

[commit-bot: I haz the power, 2015-04-15 21:20:30]

Patchset 24 (id:??) landed as
https://crrev.com/29061783f8b59f1e78286a87a3bb7d18129f639a
Cr-Commit-Position: refs/heads/master@{#325307}