Introducing FetchEventInit Dictionary.

Source/modules/serviceworkers/FetchEvent.cpp

Index: Source/modules/serviceworkers/FetchEvent.cpp
diff --git a/Source/modules/serviceworkers/FetchEvent.cpp b/Source/modules/serviceworkers/FetchEvent.cpp
index dbd4dc86d69a746de465820c9b8a28227bf7d32f..f889859065a0875879b4417abdb7bcdb5abc817a 100644
--- a/Source/modules/serviceworkers/FetchEvent.cpp
+++ b/Source/modules/serviceworkers/FetchEvent.cpp
@@ -16,9 +16,14 @@ PassRefPtrWillBeRawPtr<FetchEvent> FetchEvent::create()
     return adoptRefWillBeNoop(new FetchEvent());
 }
 
-PassRefPtrWillBeRawPtr<FetchEvent> FetchEvent::create(RespondWithObserver* observer, Request* request)
+PassRefPtrWillBeRawPtr<FetchEvent> FetchEvent::create(const AtomicString& type, const FetchEventInit& initializer)
 {
-    return adoptRefWillBeNoop(new FetchEvent(observer, request));
+    return adoptRefWillBeNoop(new FetchEvent(type, initializer));
+}
+
+PassRefPtrWillBeRawPtr<FetchEvent> FetchEvent::create(const AtomicString& type, const FetchEventInit& initializer, RespondWithObserver* observer)
+{
+    return adoptRefWillBeNoop(new FetchEvent(type, initializer, observer));
 }
 
 Request* FetchEvent::request() const
@@ -42,22 +47,28 @@ const AtomicString& FetchEvent::interfaceName() const
     return EventNames::FetchEvent;
 }
 
-void FetchEvent::setIsReload(bool isReload)
+FetchEvent::FetchEvent()
+    : m_isReload(false)
 {
-    m_isReload = isReload;
 }
 
-FetchEvent::FetchEvent()
-    : m_isReload(false)
+FetchEvent::FetchEvent(const AtomicString& type, const FetchEventInit& initializer)
+    : Event(type, /*canBubble=*/false, /*cancelable=*/true)
 {
+    if (initializer.hasRequest())
+        m_request = initializer.request();
+    if (initializer.hasIsReload())
+        m_isReload = initializer.isReload();

[tkent, 2015/04/20 23:31:41]

m_isReload is not initialized for |else| path.

[Paritosh Kumar, 2015/04/21 05:37:14]

I think this "if" is not required as initializer.hasIsReload will return always
true. Since, We are initializing isReload in FetchEventInit with false, this
will never be null.

 }
 
-FetchEvent::FetchEvent(RespondWithObserver* observer, Request* request)
-    : Event(EventTypeNames::fetch, /*canBubble=*/false, /*cancelable=*/true)
+FetchEvent::FetchEvent(const AtomicString& type, const FetchEventInit& initializer, RespondWithObserver* observer)
+    : Event(type, /*canBubble=*/false, /*cancelable=*/true)
     , m_observer(observer)
-    , m_request(request)
-    , m_isReload(false)
 {
+    if (initializer.hasRequest())
+        m_request = initializer.request();
+    if (initializer.hasIsReload())
+        m_isReload = initializer.isReload();

[tkent, 2015/04/20 23:31:41]

Ditto.

 }
 
 DEFINE_TRACE(FetchEvent)