Introducing FetchEventInit Dictionary.

Source/modules/serviceworkers/FetchEvent.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "FetchEvent.h"
 
 #include "modules/fetch/Request.h"
 #include "modules/serviceworkers/ServiceWorkerGlobalScope.h"
 #include "wtf/RefPtr.h"
 
 namespace blink {
 
 PassRefPtrWillBeRawPtr<FetchEvent> FetchEvent::create()
 {
     return adoptRefWillBeNoop(new FetchEvent());
 }
 
-PassRefPtrWillBeRawPtr<FetchEvent> FetchEvent::create(RespondWithObserver* observer, Request* request)
+PassRefPtrWillBeRawPtr<FetchEvent> FetchEvent::create(const AtomicString& type, const FetchEventInit& initializer)
 {
-    return adoptRefWillBeNoop(new FetchEvent(observer, request));
+    return adoptRefWillBeNoop(new FetchEvent(type, initializer));
+}
+
+PassRefPtrWillBeRawPtr<FetchEvent> FetchEvent::create(const AtomicString& type, const FetchEventInit& initializer, RespondWithObserver* observer)
+{
+    return adoptRefWillBeNoop(new FetchEvent(type, initializer, observer));
 }
 
 Request* FetchEvent::request() const
 {
     return m_request;
 }
 
 bool FetchEvent::isReload() const
 {
     return m_isReload;
 }
 
 void FetchEvent::respondWith(ScriptState* scriptState, const ScriptValue& value, ExceptionState& exceptionState)
 {
     stopImmediatePropagation();
     m_observer->respondWith(scriptState, value, exceptionState);
 }
 
 const AtomicString& FetchEvent::interfaceName() const
 {
     return EventNames::FetchEvent;
 }
 
-void FetchEvent::setIsReload(bool isReload)
-{
-    m_isReload = isReload;
-}
-
 FetchEvent::FetchEvent()
     : m_isReload(false)
 {
 }
 
-FetchEvent::FetchEvent(RespondWithObserver* observer, Request* request)
-    : Event(EventTypeNames::fetch, /*canBubble=*/false, /*cancelable=*/true)
+FetchEvent::FetchEvent(const AtomicString& type, const FetchEventInit& initializer)
+    : Event(type, /*canBubble=*/false, /*cancelable=*/true)
+{
+    if (initializer.hasRequest())
+        m_request = initializer.request();
+    if (initializer.hasIsReload())
+        m_isReload = initializer.isReload();

[tkent, 2015/04/20 23:31:41]

m_isReload is not initialized for |else| path.

[Paritosh Kumar, 2015/04/21 05:37:14]

I think this "if" is not required as initializer.hasIsReload will return always
true. Since, We are initializing isReload in FetchEventInit with false, this
will never be null.

+}
+
+FetchEvent::FetchEvent(const AtomicString& type, const FetchEventInit& initializer, RespondWithObserver* observer)
+    : Event(type, /*canBubble=*/false, /*cancelable=*/true)
     , m_observer(observer)
-    , m_request(request)
-    , m_isReload(false)
 {
+    if (initializer.hasRequest())
+        m_request = initializer.request();
+    if (initializer.hasIsReload())
+        m_isReload = initializer.isReload();

[tkent, 2015/04/20 23:31:41]

Ditto.

 }
 
 DEFINE_TRACE(FetchEvent)
 {
     visitor->trace(m_request);
     visitor->trace(m_observer);
     Event::trace(visitor);
 }
 
 } // namespace blink