Issue 1078983007: Revert of Initialize the new WindowProxy when handing off the global object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1078983007: Revert of Initialize the new WindowProxy when handing off the global object. (Closed)

Created:
5 years, 8 months ago by tkent

Modified:
5 years, 8 months ago

Reviewers:
haraken, dcheng

CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, vivekg, site-isolation-reviews_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Initialize the new WindowProxy when handing off the global object. (patchset #1 id:1 of https://codereview.chromium.org/1096393005/) Reason for revert: Speculative revert for RenderFrameImplTest failures blocking Blink roll http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/58952 Original issue's description: > Initialize the new WindowProxy when handing off the global object. > > BUG=480676 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194405 TBR=haraken@chromium.org,dcheng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480676 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194464

Created: 5 years, 8 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -38 lines)			Patch
	M	Source/bindings/core/v8/WindowProxy.cpp	View		2 chunks	+2 lines, -9 lines	0 comments	Download
	M	Source/web/tests/WebFrameTest.cpp	View		1 chunk	+0 lines, -29 lines	0 comments	Download

Total messages: 4 (0 generated)

tkent

Created Revert of Initialize the new WindowProxy when handing off the global object.

5 years, 8 months ago (2015-04-26 20:51:00 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078983007/1

5 years, 8 months ago (2015-04-26 20:51:02 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=194464

5 years, 8 months ago (2015-04-26 20:51:56 UTC) #3

Message was sent while issue was closed.

LGTM