Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 1078943002: remove 'widows' property because paged media support is gone so this does nothing now (Closed)

Created:
5 years, 8 months ago by Hixie
Modified:
5 years, 8 months ago
Reviewers:
eseidel
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

remove 'widows' property because paged media support is gone so this does nothing now R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8f278611528a39661591697667945d08f0a63404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -60 lines) Patch
M sky/engine/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/animation/css/CSSPropertyEquality.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/css/CSSProperties.in View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/StylePropertySet.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/core/css/resolver/AnimatedStyleBuilder.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/editing/EditingStyle.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 3 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareInheritedData.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareInheritedData.cpp View 4 chunks +0 lines, -25 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
eseidel
lgtm
5 years, 8 months ago (2015-04-09 21:23:04 UTC) #2
Hixie
5 years, 8 months ago (2015-04-09 21:35:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8f278611528a39661591697667945d08f0a63404 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698