Chromium Code Reviews| Index: content/browser/web_contents/web_contents_impl.cc |
| =================================================================== |
| --- content/browser/web_contents/web_contents_impl.cc (revision 239602) |
| +++ content/browser/web_contents/web_contents_impl.cc (working copy) |
| @@ -2768,6 +2768,18 @@ |
| return OnMessageReceived(NULL, render_frame_host, message); |
| } |
| +void WebContentsImpl::RenderFrameCreated(RenderFrameHost* render_frame_host) { |
| + FOR_EACH_OBSERVER(WebContentsObserver, |
|
Charlie Reis
2013/12/10 00:31:48
Maybe mention that this is only for subframes, and
jam
2013/12/10 00:48:43
Done.
|
| + observers_, |
| + RenderFrameCreated(render_frame_host)); |
| +} |
| + |
| +void WebContentsImpl::RenderFrameDeleted(RenderFrameHost* render_frame_host) { |
| + FOR_EACH_OBSERVER(WebContentsObserver, |
| + observers_, |
| + RenderFrameDeleted(render_frame_host)); |
| +} |
| + |
| RenderViewHostDelegateView* WebContentsImpl::GetDelegateView() { |
| return render_view_host_delegate_view_; |
| } |
| @@ -2828,6 +2840,13 @@ |
| FOR_EACH_OBSERVER( |
| WebContentsObserver, observers_, RenderViewCreated(render_view_host)); |
| + |
| + // We tell the observers now instead of when the main render frame is |
| + // constructed because otherwise it would be too early (i.e. IPCs sent to the |
| + // frame would be dropped because it's not created yet). |
|
Charlie Reis
2013/12/10 00:31:48
If I understand correctly, maybe say "main RenderF
jam
2013/12/10 00:48:43
Done.
|
| + RenderFrameHost* main_frame = GetMainFrame(); |
| + FOR_EACH_OBSERVER( |
| + WebContentsObserver, observers_, RenderFrameCreated(main_frame)); |
| } |
| void WebContentsImpl::RenderViewReady(RenderViewHost* rvh) { |