Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1078923002: Use fake media stream in ContentPreferencesTest#testCameraMicNotBlocked (Closed)

Created:
5 years, 8 months ago by mckev
Modified:
5 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use fake media stream in ContentPreferencesTest#testCameraMicNotBlocked This adds the --use-fake-device-for-media-stream flag to the ChromeShell test ContentPreferencesTest#testCameraMicNotBlocked, so that it can succeed when running on a device that does not have a microphone. BUG=475675 TEST=ContentPreferencesTest#testCameraMicNotBlocked Committed: https://crrev.com/1fac33fdb1dfb54fbad06fbd3f4cbbfd3d2e52cc Cr-Commit-Position: refs/heads/master@{#326647}

Patch Set 1 #

Patch Set 2 : Removed change to getusermedia.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/ChromeSwitches.java View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/ContentPreferencesTest.java View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
mckev
Hi Ted! Here's a proposed fix for crbug 475675. Please let me know if you ...
5 years, 8 months ago (2015-04-09 21:00:43 UTC) #2
Ted C
+perkj -- the original author of that TODO. +qinmin -- our media expert on android ...
5 years, 8 months ago (2015-04-09 21:18:14 UTC) #4
mckev
On 2015/04/09 21:18:14, Ted C wrote: > +perkj -- the original author of that TODO. ...
5 years, 8 months ago (2015-04-09 21:21:49 UTC) #5
qinmin
lgtm
5 years, 8 months ago (2015-04-14 18:48:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078923002/20001
5 years, 8 months ago (2015-04-14 19:17:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/56302)
5 years, 8 months ago (2015-04-14 19:25:48 UTC) #11
mckev
On 2015/04/14 19:25:48, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 8 months ago (2015-04-14 21:51:43 UTC) #12
Ted C
lgtm
5 years, 8 months ago (2015-04-23 20:59:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078923002/20001
5 years, 8 months ago (2015-04-23 21:04:46 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-23 21:30:21 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 21:31:10 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1fac33fdb1dfb54fbad06fbd3f4cbbfd3d2e52cc
Cr-Commit-Position: refs/heads/master@{#326647}

Powered by Google App Engine
This is Rietveld 408576698