Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: tools/mb/mb.py

Issue 1078913003: Fix error code propagation in 'mb gen'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clean up test code Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/mb/mb_unittest.py » ('j') | tools/mb/mb_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/mb/mb.py
diff --git a/tools/mb/mb.py b/tools/mb/mb.py
index 0b5775e9f2069fb887144b1deda0ef700a8763d3..bc43654ee03773a328a95e52dd0218cc3bc0b004 100755
--- a/tools/mb/mb.py
+++ b/tools/mb/mb.py
@@ -122,12 +122,11 @@ class MetaBuildWrapper(object):
def CmdGen(self):
vals = self.GetConfig()
if vals['type'] == 'gn':
- self.RunGNGen(self.args.path[0], vals)
- elif vals['type'] == 'gyp':
- self.RunGYPGen(self.args.path[0], vals)
- else:
- raise MBErr('Unknown meta-build type "%s"' % vals['type'])
- return 0
+ return self.RunGNGen(self.args.path[0], vals)
+ if vals['type'] == 'gyp':
+ return self.RunGYPGen(self.args.path[0], vals)
+
+ raise MBErr('Unknown meta-build type "%s"' % vals['type'])
def CmdLookup(self):
vals = self.GetConfig()
« no previous file with comments | « no previous file | tools/mb/mb_unittest.py » ('j') | tools/mb/mb_unittest.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698