Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1078913003: Fix error code propagation in 'mb gen'. (Closed)

Created:
5 years, 8 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix error code propagation in 'mb gen'. If the underlying call to 'gn gen' (or gyp_chromium) failed, mb was swallowing the error. R=brettw@chromium.org BUG= Committed: https://crrev.com/08d2ab130415694f0db6ef89605b984758ab4822 Cr-Commit-Position: refs/heads/master@{#326892}

Patch Set 1 #

Patch Set 2 : clean up test code #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M tools/mb/mb.py View 1 chunk +5 lines, -6 lines 0 comments Download
M tools/mb/mb_unittest.py View 1 2 chunks +8 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
Dirk Pranke
5 years, 8 months ago (2015-04-24 20:36:16 UTC) #1
Dirk Pranke
https://codereview.chromium.org/1078913003/diff/20001/tools/mb/mb_unittest.py File tools/mb/mb_unittest.py (right): https://codereview.chromium.org/1078913003/diff/20001/tools/mb/mb_unittest.py#newcode105 tools/mb/mb_unittest.py:105: mbw.files.setdefault(mbw.default_config, TEST_CONFIG) these diffs are unrelated to the fix, ...
5 years, 8 months ago (2015-04-24 20:38:52 UTC) #2
brettw
lgtm
5 years, 8 months ago (2015-04-24 20:41:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078913003/20001
5 years, 8 months ago (2015-04-24 20:42:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 21:54:28 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 21:55:42 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/08d2ab130415694f0db6ef89605b984758ab4822
Cr-Commit-Position: refs/heads/master@{#326892}

Powered by Google App Engine
This is Rietveld 408576698