Issue 1078903002: Collect list of requested modules in ModuleDescriptor while parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1078903002: Collect list of requested modules in ModuleDescriptor while parsing (Closed)

Created:
5 years, 8 months ago by adamk

Modified:
5 years, 8 months ago

Reviewers:
arv (Not doing code reviews)

CC:
v8-dev, rossberg

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Collect list of requested modules in ModuleDescriptor while parsing BUG=v8:1569 LOG=n Committed: https://crrev.com/52bbb4f6091ca0f0177a54a47fdb7ced9057b6e6 Cr-Commit-Position: refs/heads/master@{#27724}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -4 lines)			Patch
M	src/modules.h	View	4 chunks	+16 lines, -3 lines	0 comments	Download
M	src/modules.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/parser.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	2 chunks	+8 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

adamk

This obviously isn't terribly useful by itself, but it's a necessary step and I figured ...

5 years, 8 months ago (2015-04-09 20:29:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078903002/1

5 years, 8 months ago (2015-04-09 21:53:57 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-09 22:10:03 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/52bbb4f6091ca0f0177a54a47fdb7ced9057b6e6
Cr-Commit-Position: refs/heads/master@{#27724}