Issue 1078883003: remove 'page' and 'size' since those are for printing, and that's obsolete in our world now

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1078883003: remove 'page' and 'size' since those are for printing, and that's obsolete in our world now (Closed)

Created:
5 years, 8 months ago by Hixie

Modified:
5 years, 8 months ago

Reviewers:
eseidel

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

remove 'page' and 'size' since those are for printing, and that's obsolete in our world now Also it seems we're not parsing @page rules anyway, so this was presumably dead code. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8f08530547ebcf0860a7efc8c17c3b2b3c93ed51

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -295 lines)			Patch
M	sky/engine/core/css/CSSComputedStyleDeclaration.cpp	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/css/CSSProperties.in	View	1	2 chunks	+0 lines, -10 lines	0 comments	Download
M	sky/engine/core/css/parser/CSSPropertyParser.h	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	sky/engine/core/css/parser/CSSPropertyParser.cpp	View		3 chunks	+0 lines, -99 lines	0 comments	Download
M	sky/engine/core/css/resolver/StyleBuilderCustom.cpp	View		1 chunk	+0 lines, -145 lines	0 comments	Download
M	sky/engine/core/rendering/style/RenderStyle.h	View	1	2 chunks	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/rendering/style/StyleRareNonInheritedData.h	View		3 chunks	+0 lines, -13 lines	0 comments	Download
M	sky/engine/core/rendering/style/StyleRareNonInheritedData.cpp	View		3 chunks	+0 lines, -6 lines	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 8 months ago (2015-04-09 22:07:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
8f08530547ebcf0860a7efc8c17c3b2b3c93ed51 (presubmit successful).