Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: tests/html/svgelement_test.dart

Issue 1078853002: Remove SVG constructor suppressions around foreignobject and altGlyph (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Trailing whitespace Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/html/html.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/html/svgelement_test.dart
diff --git a/tests/html/svgelement_test.dart b/tests/html/svgelement_test.dart
index 7ab3d51383dca9f2f14e42a360d72832cc2f7df9..3fd62f3ebd5e642b0b807105b9d47a538ac5a3f6 100644
--- a/tests/html/svgelement_test.dart
+++ b/tests/html/svgelement_test.dart
@@ -29,11 +29,13 @@ main() {
};
testConstructor(String tagName, Function isExpectedClass,
- [bool expectation = true]) {
+ [bool expectation = true, allowsInnerHtml = true]) {
test(tagName, () {
expect(isExpectedClass(new svg.SvgElement.tag(tagName)), expectation);
- expect(isExpectedClass(
- new svg.SvgElement.svg('<$tagName></$tagName>')), expectation);
+ if (allowsInnerHtml) {
+ expect(isExpectedClass(new svg.SvgElement.svg('<$tagName></$tagName>')),
+ allowsInnerHtml);
+ }
});
}
group('additionalConstructors', () {
@@ -243,7 +245,6 @@ main() {
});
group('constructors', () {
- group('supported', () {
testConstructor('a', (e) => e is svg.AElement);
testConstructor('circle', (e) => e is svg.CircleElement);
testConstructor('clipPath', (e) => e is svg.ClipPathElement);
@@ -275,8 +276,9 @@ main() {
testConstructor('title', (e) => e is svg.TitleElement);
testConstructor('use', (e) => e is svg.UseElement);
testConstructor('view', (e) => e is svg.ViewElement);
+ // TODO(alanknight): Issue 23144
testConstructor('altGlyph', (e) => e is svg.AltGlyphElement,
- svg.AltGlyphElement.supported);
+ svg.AltGlyphElement.supported, false);
testConstructor('animate', (e) => e is svg.AnimateElement,
svg.AnimateElement.supported);
testConstructor('animateMotion', (e) => e is svg.AnimateMotionElement,
@@ -335,11 +337,10 @@ main() {
testConstructor('filter', (e) => e is svg.FilterElement,
svg.FilterElement.supported);
testConstructor('foreignObject', (e) => e is svg.ForeignObjectElement,
- svg.ForeignObjectElement.supported);
+ svg.ForeignObjectElement.supported, false);
testConstructor('metadata', (e) => e is svg.MetadataElement);
testConstructor('set', (e) => e is svg.SetElement,
svg.SetElement.supported);
- });
});
group('outerHtml', () {
« no previous file with comments | « tests/html/html.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698