Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1078843002: default to 8888 for ganesh in sampleapp on iOS (Closed)

Created:
5 years, 8 months ago by reed1
Modified:
5 years, 8 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

default to 8888 for ganesh in sampleapp on iOS BUG=skia: Committed: https://skia.googlesource.com/skia/+/a1e41c6d9a2029eb836c6120bb154ccd25e1588d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M experimental/iOSSampleApp/SkSampleUIView.mm View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
reed1
8888 for ganesh
5 years, 8 months ago (2015-04-09 18:19:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078843002/1
5 years, 8 months ago (2015-04-09 18:20:04 UTC) #4
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-09 18:34:57 UTC) #6
robertphillips
lgtm
5 years, 8 months ago (2015-04-09 19:29:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078843002/1
5 years, 8 months ago (2015-04-09 20:43:10 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 20:43:26 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a1e41c6d9a2029eb836c6120bb154ccd25e1588d

Powered by Google App Engine
This is Rietveld 408576698