Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 1078813002: Remove //mojo/tools/package_manager. (Closed)

Created:
5 years, 8 months ago by viettrungluu
Modified:
5 years, 8 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove //mojo/tools/package_manager. It's not used (nor being worked on), AFAIK. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f574a891a6e7477948fe19826f6fe5354ea8d10a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -584 lines) Patch
M mojo/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/tools/package_manager/BUILD.gn View 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/tools/package_manager/manifest.h View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/tools/package_manager/manifest.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D mojo/tools/package_manager/package_fetcher.h View 1 chunk +0 lines, -63 lines 0 comments Download
D mojo/tools/package_manager/package_fetcher.cc View 1 chunk +0 lines, -96 lines 0 comments Download
D mojo/tools/package_manager/package_manager.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/tools/package_manager/package_manager_application.h View 1 chunk +0 lines, -63 lines 0 comments Download
D mojo/tools/package_manager/package_manager_application.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D mojo/tools/package_manager/unpacker.h View 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/tools/package_manager/unpacker.cc View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 8 months ago (2015-04-09 16:57:00 UTC) #1
jamesr
lgtm
5 years, 8 months ago (2015-04-09 21:56:20 UTC) #2
viettrungluu
5 years, 8 months ago (2015-04-09 22:10:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f574a891a6e7477948fe19826f6fe5354ea8d10a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698