Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: public/platform/modules/notifications/WebNotificationManager.h

Issue 1078783002: Update the Notification Blink API to use integral persistent ids. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/ServiceWorkerGlobalScopeProxy.cpp ('k') | public/web/WebServiceWorkerContextProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/modules/notifications/WebNotificationManager.h
diff --git a/public/platform/modules/notifications/WebNotificationManager.h b/public/platform/modules/notifications/WebNotificationManager.h
index 53b092f8a5487a41cb2cd6230467e54f69857a92..d8432293b85b1481226c8efb5f41b05e5174e3f1 100644
--- a/public/platform/modules/notifications/WebNotificationManager.h
+++ b/public/platform/modules/notifications/WebNotificationManager.h
@@ -11,6 +11,7 @@
#include "public/platform/WebVector.h"
#include "public/platform/modules/notifications/WebNotificationData.h"
#include "public/platform/modules/notifications/WebNotificationPermission.h"
+#include <stdint.h>
namespace blink {
@@ -20,7 +21,10 @@ class WebServiceWorkerRegistration;
// Structure representing the info associated with a persistent notification.
struct WebPersistentNotificationInfo {
+ // TODO(peter): Remove the string property when Chromium has switched over.
WebString persistentNotificationId;
+
+ int64_t persistentId = 0;
WebNotificationData data;
};
@@ -44,16 +48,22 @@ public:
// Asynchronously gets the persistent notifications belonging to the Service Worker Registration.
// If |filterTag| is not an empty string, only the notification with the given tag will be
// considered. Will take ownership of the WebNotificationGetCallbacks object.
- virtual void getNotifications(const WebString& filterTag, WebServiceWorkerRegistration*, WebNotificationGetCallbacks*)
- {
- BLINK_ASSERT_NOT_REACHED();
- }
+ virtual void getNotifications(const WebString& filterTag, WebServiceWorkerRegistration*, WebNotificationGetCallbacks*) = 0;
// Closes a notification previously shown, and removes it if being shown.
virtual void close(WebNotificationDelegate*) = 0;
// Closes a persistent notification identified by its persistent notification Id.
- virtual void closePersistent(const WebSerializedOrigin&, const WebString& persistentNotificationId) = 0;
+ virtual void closePersistent(const WebSerializedOrigin&, int64_t persistentNotificationId)
+ {
+ BLINK_ASSERT_NOT_REACHED();
+ }
+
+ // TODO(peter): Remove this method when the embedder accepts integral persistent ids.
+ virtual void closePersistent(const WebSerializedOrigin&, const WebString& persistentNotificationId)
+ {
+ BLINK_ASSERT_NOT_REACHED();
+ }
// Indicates that the delegate object is being destroyed, and must no longer
// be used by the embedder to dispatch events.
« no previous file with comments | « Source/web/ServiceWorkerGlobalScopeProxy.cpp ('k') | public/web/WebServiceWorkerContextProxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698