chrome/browser/password_manager/chrome_password_manager_client.cc - Issue 1078723002: Removes fullfilled TODO.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 1078723002: Removes fullfilled TODO. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/password_manager/chrome_password_manager_client.cc

diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc

index fca96ee343470be110798ec4dbd8a162baf70b83..3e90c9cf344b6d4e6d0eee082b24b06617413cc7 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client.cc

+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc

@@ -229,8 +229,6 @@ bool ChromePasswordManagerClient::PromptUserToSavePassword(

ManagePasswordsUIController::FromWebContents(web_contents());

manage_passwords_ui_controller->OnPasswordSubmitted(form_to_save.Pass());

} else {

- // TODO(melandory): If type is CREDENTIAL_SOURCE_API then new bubble should

- // be shown.

std::string uma_histogram_suffix(

password_manager::metrics_util::GroupIdToString(

password_manager::metrics_util::MonitoredDomainGroupId(

« no previous file with comments | « no previous file | no next file » | no next file with comments »