Supervised users: Re-check ManagementPolicy when ProfileIsSupervised changes.

Supervised users: Re-check ManagementPolicy when ProfileIsSupervised changes.

Add a test to make sure this happens, and while we're here, clean up some other supervised users+extensions tests.

Also, yak shaving: Rebuild the avatar menu when a profile's "IsOmitted" state changes.

BUG=397951
Committed: https://crrev.com/9e30e307e27f6ce8bfa373a29a19ac4fad431925
Cr-Commit-Position: refs/heads/master@{#325208}

[Marc Treib, 2015-04-09 12:10:50]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org

[Marc Treib, 2015-04-09 12:10:51]

PTAL!

[Bernhard Bauer, 2015-04-09 12:15:05]

https://codereview.chromium.org/1078713002/diff/1/chrome/test/base/testing_pr...
File chrome/test/base/testing_profile.cc (right):

https://codereview.chromium.org/1078713002/diff/1/chrome/test/base/testing_pr...
chrome/test/base/testing_profile.cc:770: supervised_user_id_ = id;
You could change the pref from here :)

[Marc Treib, 2015-04-09 12:37:27]

https://codereview.chromium.org/1078713002/diff/1/chrome/test/base/testing_pr...
File chrome/test/base/testing_profile.cc (right):

https://codereview.chromium.org/1078713002/diff/1/chrome/test/base/testing_pr...
chrome/test/base/testing_profile.cc:770: supervised_user_id_ = id;
On 2015/04/09 12:15:05, Bernhard Bauer wrote:
> You could change the pref from here :)

Done.

[Bernhard Bauer, 2015-04-09 12:39:38]

LGTM (meant to say that before)

[Marc Treib, 2015-04-09 12:42:10]

treib@chromium.org changed reviewers:
+ jcivelli@chromium.org, kalman@chromium.org

[Marc Treib, 2015-04-09 12:42:11]

+kalman for extension_service_unittest.cc
+jcivelli for testing_profile.h/cc

Can I get OWNERS approval, please? Thanks!

[not at google - send to devlin, 2015-04-09 14:58:52]

lgtm

https://codereview.chromium.org/1078713002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_service_unittest.cc (right):

https://codereview.chromium.org/1078713002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_service_unittest.cc:6633: class
StubSupervisedUserServiceDelegate
Perhaps ScopedSupervisedUserServiceDelegate would be a more descriptive name?
That's basically what this is doing, right; implementing an RAII Delegate?

[Marc Treib, 2015-04-09 15:07:49]

https://codereview.chromium.org/1078713002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_service_unittest.cc (right):

https://codereview.chromium.org/1078713002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_service_unittest.cc:6633: class
StubSupervisedUserServiceDelegate
On 2015/04/09 14:58:52, kalman wrote:
> Perhaps ScopedSupervisedUserServiceDelegate would be a more descriptive name?
> That's basically what this is doing, right; implementing an RAII Delegate?

Yup, good idea! Done.

[Jay Civelli, 2015-04-13 16:38:23]

LGTM for chrome/test/base

[Marc Treib, 2015-04-13 16:38:57]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2015-04-13 16:38:57]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1078713002/#ps40001
(title: "kalman review")

[commit-bot: I haz the power, 2015-04-13 16:39:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1078713002/40001

[commit-bot: I haz the power, 2015-04-13 19:21:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-13 19:21:24]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Marc Treib, 2015-04-14 13:30:44]

treib@chromium.org changed reviewers:
+ mlerman@chromium.org, shess@chromium.org

[Marc Treib, 2015-04-14 13:30:45]

Adding OWNERS for the yak shaving part.

shess: Please look at profile_menu_controller_unittest.mm

mlerman: Please look at c/b/profiles

Thanks!

[Mike Lerman, 2015-04-14 13:44:40]

LGTM for profiles.

[Scott Hess - ex-Googler, 2015-04-14 20:35:48]

LGTM for Cocoa!

[Insert picture of "I don't know what I'm doing" dog here.]

[Marc Treib, 2015-04-15 08:07:19]

Yay! Thanks, everyone!

[Marc Treib, 2015-04-15 08:07:23]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2015-04-15 08:07:24]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
jcivelli@chromium.org, kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1078713002/#ps80001
(title: "shaving the yak")

[commit-bot: I haz the power, 2015-04-15 08:07:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1078713002/80001

[commit-bot: I haz the power, 2015-04-15 08:12:32]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-15 08:13:17]

Patchset 5 (id:??) landed as
https://crrev.com/9e30e307e27f6ce8bfa373a29a19ac4fad431925
Cr-Commit-Position: refs/heads/master@{#325208}